From: Weston Andros Adamson <dros@primarydata.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Peng Tao <bergwolf@primarydata.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] NFS: fix subtle change in COMMIT behavior
Date: Thu, 13 Nov 2014 08:38:15 -0500 [thread overview]
Message-ID: <6E1CB959-CB60-4AE3-9392-65ABDF0DB2F0@primarydata.com> (raw)
In-Reply-To: <20141113110244.GA25709@lst.de>
> On Nov 13, 2014, at 6:02 AM, Christoph Hellwig <hch@lst.de> wrote:
>
> On Thu, Nov 13, 2014 at 09:03:53AM +0800, Peng Tao wrote:
>>> but should be contiguous (as enforced by nfs_flush_incompatible).
>>>
>> The idea is to get an estimation on the length of layout that client
>> wants to use. So even if a single byte is used by client, client would
>> want to ask for a layout that covers the whole page.
>
> That code is very non-obvious and could use a few more comments.
>
> I think the NFS_I(inode)->npages should be replaced with
> inode->i_mapping->nrpages which counts the number of page cache pages.
That sounds reasonable. Can someone track this down? I don’t have a block
server to test against…
Thanks for the help Tao and Christoph!
-dros
next prev parent reply other threads:[~2014-11-13 13:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 17:08 [PATCH] NFS: fix subtle change in COMMIT behavior Weston Andros Adamson
2014-11-13 1:03 ` Peng Tao
2014-11-13 11:02 ` Christoph Hellwig
2014-11-13 13:38 ` Weston Andros Adamson [this message]
2014-11-13 13:38 ` Christoph Hellwig
2014-11-14 7:04 ` Christoph Hellwig
2014-11-14 15:02 ` Weston Andros Adamson
2014-11-24 22:04 ` Trond Myklebust
2014-11-24 23:47 ` Tom Haynes
2014-11-25 13:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6E1CB959-CB60-4AE3-9392-65ABDF0DB2F0@primarydata.com \
--to=dros@primarydata.com \
--cc=bergwolf@primarydata.com \
--cc=hch@lst.de \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox