* 3.17.x 3.18.x nfs_permission(): put_rpccred() missing?
@ 2014-12-21 11:40 Frank van Maarseveen
2014-12-22 16:21 ` Trond Myklebust
0 siblings, 1 reply; 2+ messages in thread
From: Frank van Maarseveen @ 2014-12-21 11:40 UTC (permalink / raw)
To: Linux NFS mailing list
While updating the nfs-ngroups patch for 3.17 and 3.18 I noticed that
nfs_permission() seems to be missing a put_rpccred() call in the non
-ECHILD path.
--
Frank
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 3.17.x 3.18.x nfs_permission(): put_rpccred() missing?
2014-12-21 11:40 3.17.x 3.18.x nfs_permission(): put_rpccred() missing? Frank van Maarseveen
@ 2014-12-22 16:21 ` Trond Myklebust
0 siblings, 0 replies; 2+ messages in thread
From: Trond Myklebust @ 2014-12-22 16:21 UTC (permalink / raw)
To: Frank van Maarseveen; +Cc: Linux NFS mailing list
Hi Frank,
On Sun, Dec 21, 2014 at 6:40 AM, Frank van Maarseveen
<frankvm@frankvm.com> wrote:
> While updating the nfs-ngroups patch for 3.17 and 3.18 I noticed that
> nfs_permission() seems to be missing a put_rpccred() call in the non
> -ECHILD path.
I fully agree that it is confusing, but the current code is actually
correct. Please see the changelog for commit bd95608053b7f
(sunrpc/auth: allow lockless (rcu) lookup of credential cache.) which
explains the rules for the RCU-safe credential lookup.
We definitely do want to document this behaviour a little better in
the source. Any takers?
Cheers,
Trond
--
Trond Myklebust
Linux NFS client maintainer, PrimaryData
trond.myklebust@primarydata.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-12-22 16:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-21 11:40 3.17.x 3.18.x nfs_permission(): put_rpccred() missing? Frank van Maarseveen
2014-12-22 16:21 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox