From: NeilBrown <neilb@suse.de>
To: Nix <nix@esperi.org.uk>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
NFS list <linux-nfs@vger.kernel.org>,
Trond Myklebust <trond.myklebust@primarydata.com>
Subject: Re: what on earth is going on here? paths above mountpoints turn into "(unreachable)"
Date: Sat, 21 Feb 2015 08:03:21 +1100 [thread overview]
Message-ID: <20150221080321.0b2764c0@notabene.brown> (raw)
In-Reply-To: <87h9ugqytn.fsf@spindle.srvr.nix>
[-- Attachment #1: Type: text/plain, Size: 1033 bytes --]
On Fri, 20 Feb 2015 17:26:12 +0000 Nix <nix@esperi.org.uk> wrote:
> On 16 Feb 2015, NeilBrown uttered the following:
>
> > On Mon, 16 Feb 2015 13:46:28 +1100 NeilBrown <neilb@suse.de> wrote:
> >
> >> Anyway, please try:
> >>
> >> diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> >> index 9b0c55cb2a2e..a460669dc395 100644
> >> --- a/fs/nfs/dir.c
> >> +++ b/fs/nfs/dir.c
> >> @@ -541,7 +541,7 @@ int nfs_readdir_page_filler(nfs_readdir_descriptor_t *desc, struct nfs_entry *en
> >>
> >> count++;
> >>
> >> - if (desc->plus != 0)
> >> + if (desc->plus != 0 && entry->fh.size)
> >> nfs_prime_dcache(desc->file->f_path.dentry, entry);
> >>
> >> status = nfs_readdir_add_to_array(entry, page);
> >>
> >>
> >> which you might have to apply by hand.
> >
> > Make that "entry->fh->size", not "entry->fh.size" :-(
>
> That looks to fix it (though my first day of testing was wasted because
> I forgot nordirplus was in the mount options :/ ).
>
Excellent. Thanks for testing.
NeilBrown
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
next prev parent reply other threads:[~2015-02-20 21:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-03 0:25 what on earth is going on here? paths above mountpoints turn into "(unreachable)" Nix
2015-02-03 19:53 ` J. Bruce Fields
2015-02-03 19:57 ` Nix
2015-02-04 23:28 ` Nix
2015-02-05 0:26 ` NeilBrown
2015-02-10 17:48 ` Nix
2015-02-10 18:32 ` J. Bruce Fields
2015-02-11 23:07 ` Nix
2015-02-11 23:18 ` NeilBrown
2015-02-12 1:50 ` Nix
2015-02-12 15:38 ` J. Bruce Fields
2015-02-14 13:17 ` Nix
2015-02-16 2:46 ` NeilBrown
2015-02-16 3:57 ` NeilBrown
2015-02-17 17:32 ` Nix
2015-02-20 17:26 ` Nix
2015-02-20 21:03 ` NeilBrown [this message]
2015-02-16 4:28 ` Trond Myklebust
2015-02-16 4:54 ` NeilBrown
2015-02-22 22:13 ` Trond Myklebust
2015-02-22 22:47 ` NeilBrown
2015-02-23 2:05 ` Trond Myklebust
2015-02-23 2:33 ` Trond Myklebust
2015-02-23 3:05 ` NeilBrown
2015-02-23 3:33 ` Trond Myklebust
2015-02-23 4:49 ` NeilBrown
2015-02-23 13:55 ` Trond Myklebust
2015-02-16 15:43 ` J. Bruce Fields
2015-02-11 3:07 ` NeilBrown
2015-02-11 23:11 ` Nix
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150221080321.0b2764c0@notabene.brown \
--to=neilb@suse.de \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nix@esperi.org.uk \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox