From: Christoph Hellwig <hch@infradead.org>
To: Kinglong Mee <kinglongmee@gmail.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Trond Myklebust <trond.myklebust@primarydata.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH, RFC] backchannel overflows
Date: Wed, 29 Apr 2015 06:46:31 -0700 [thread overview]
Message-ID: <20150429134631.GA17647@infradead.org> (raw)
In-Reply-To: <5540C9BD.2080402@gmail.com>
On Wed, Apr 29, 2015 at 08:08:29PM +0800, Kinglong Mee wrote:
> > diff --git a/fs/nfs/callback.h b/fs/nfs/callback.h
> > index 84326e9..7afb3ef 100644
> > --- a/fs/nfs/callback.h
> > +++ b/fs/nfs/callback.h
> > @@ -205,7 +205,7 @@ extern int nfs4_set_callback_sessionid(struct nfs_client *clp);
> > * so we limit their concurrency to 1 by setting up the maximum number
> > * of slots for the backchannel.
> > */
> > -#define NFS41_BC_MIN_CALLBACKS 1
> > +#define NFS41_BC_MIN_CALLBACKS 2
> > #define NFS41_BC_MAX_CALLBACKS 1
>
> Are you sure that's okay without update NFS41_BC_MAX_CALLBACKS?
Yes, NFS41_BC_MIN_CALLBACKS is the number of slots we tell the sunrpc
layer to allocate, while NFS41_BC_MAX_CALLBACKS is used for nfs-internal
accounting. So having them different is intentional for this rfc. If
we'll have to merge this instead of a better fix we defintively should
fix up the naming, though.
next prev parent reply other threads:[~2015-04-29 13:46 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 20:21 [PATCH, RFC] backchannel overflows Christoph Hellwig
2015-04-29 12:08 ` Kinglong Mee
2015-04-29 13:46 ` Christoph Hellwig [this message]
2015-04-29 14:55 ` Chuck Lever
2015-04-29 14:58 ` Trond Myklebust
2015-04-29 15:14 ` Christoph Hellwig
2015-04-29 15:24 ` Trond Myklebust
2015-04-29 17:34 ` J. Bruce Fields
2015-04-30 6:25 ` Christoph Hellwig
2015-04-30 14:34 ` Chuck Lever
2015-04-30 14:37 ` Christoph Hellwig
[not found] ` <CAHQdGtRgEVXidNNYtYf4c3uS0vc6fbm-SZ5AxrY=awXYynmACw@mail.gmail.com>
2015-04-30 15:02 ` Trond Myklebust
2015-04-30 15:11 ` Chuck Lever
2015-04-30 17:41 ` Chuck Lever
2015-05-01 17:23 ` Christoph Hellwig
2015-05-01 17:28 ` Trond Myklebust
2015-05-01 17:37 ` Christoph Hellwig
2015-05-01 17:47 ` Trond Myklebust
2015-05-01 17:31 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429134631.GA17647@infradead.org \
--to=hch@infradead.org \
--cc=kinglongmee@gmail.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox