Linux NFS development
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: linux-rdma@vger.kernel.org, linux-nfs@vger.kernel.org
Subject: [PATCH v2 02/11] xprtrdma: xprt_rdma_free() must not release backchannel reqs
Date: Mon, 30 Nov 2015 17:14:14 -0500	[thread overview]
Message-ID: <20151130221414.12235.17712.stgit@manet.1015granger.net> (raw)
In-Reply-To: <20151130221349.12235.29565.stgit@manet.1015granger.net>

Preserve any rpcrdma_req that is attached to rpc_rqst's allocated
for the backchannel. Otherwise, after all the pre-allocated
backchannel req's are consumed, incoming backward calls start
writing on freed memory.

Somehow this hunk got lost.

Fixes: f531a5dbc451 ('xprtrdma: Pre-allocate backward rpc_rqst')
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 net/sunrpc/xprtrdma/transport.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/net/sunrpc/xprtrdma/transport.c b/net/sunrpc/xprtrdma/transport.c
index 8c545f7..740bddc 100644
--- a/net/sunrpc/xprtrdma/transport.c
+++ b/net/sunrpc/xprtrdma/transport.c
@@ -576,6 +576,9 @@ xprt_rdma_free(void *buffer)
 
 	rb = container_of(buffer, struct rpcrdma_regbuf, rg_base[0]);
 	req = rb->rg_owner;
+	if (req->rl_backchannel)
+		return;
+
 	r_xprt = container_of(req->rl_buffer, struct rpcrdma_xprt, rx_buf);
 
 	dprintk("RPC:       %s: called on 0x%p\n", __func__, req->rl_reply);


  parent reply	other threads:[~2015-11-30 22:14 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-30 22:13 [PATCH v2 00/11] NFS/RDMA client patches for 4.5 Chuck Lever
2015-11-30 22:14 ` [PATCH v2 01/11] xprtrdma: Fix additional uses of spin_lock_irqsave(rb_lock) Chuck Lever
2015-11-30 22:14 ` Chuck Lever [this message]
2015-11-30 22:14 ` [PATCH v2 03/11] xprtrdma: Disable RPC/RDMA backchannel debugging messages Chuck Lever
2015-11-30 22:14 ` [PATCH v2 04/11] xprtrdma: Move struct ib_send_wr off the stack Chuck Lever
2015-11-30 22:14 ` [PATCH v2 05/11] xprtrdma: Introduce ro_unmap_sync method Chuck Lever
2015-11-30 22:14 ` [PATCH v2 06/11] xprtrdma: Add ro_unmap_sync method for FRWR Chuck Lever
2015-11-30 22:14 ` [PATCH v2 07/11] xprtrdma: Add ro_unmap_sync method for FMR Chuck Lever
2015-11-30 22:15 ` [PATCH v2 08/11] xprtrdma: Add ro_unmap_sync method for all-physical registration Chuck Lever
2015-11-30 22:15 ` [PATCH v2 09/11] SUNRPC: Introduce xprt_commit_rqst() Chuck Lever
2015-11-30 22:15 ` [PATCH v2 10/11] xprtrdma: Invalidate in the RPC reply handler Chuck Lever
2015-11-30 22:15 ` [PATCH v2 11/11] xprtrdma: Revert commit e7104a2a9606 ('xprtrdma: Cap req_cqinit') Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20151130221414.12235.17712.stgit@manet.1015granger.net \
    --to=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox