From: Christoph Hellwig <hch@infradead.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Jeff Layton <jlayton@poochiereds.net>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH v2 02/10] NFS: Move the flock open mode check into nfs_flock()
Date: Mon, 7 Dec 2015 11:22:22 -0800 [thread overview]
Message-ID: <20151207192222.GA7938@infradead.org> (raw)
In-Reply-To: <alpine.OSX.2.19.9992.1512071359370.60717@planck.local>
On Mon, Dec 07, 2015 at 02:13:47PM -0500, Benjamin Coddington wrote:
> I can fixup the comment for clarity as I just moved this chunk over.
>
> I'm not aware that flock() has ever had this check, but posix locks requires
> it. My understanding is that since NFS may simulate flock() with posix
> locking, the check is necessary for NFS.
Ah, right. Maybe that's what should be in the comment here..
next prev parent reply other threads:[~2015-12-07 19:22 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-07 16:25 [PATCH v2 00/10] locking fixups for NFS Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 01/10] NFS4: remove a redundant lock range check Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 02/10] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2015-12-07 18:40 ` Christoph Hellwig
2015-12-07 19:13 ` Benjamin Coddington
2015-12-07 19:22 ` Christoph Hellwig [this message]
2015-12-07 19:24 ` Benjamin Coddington
2015-12-27 3:13 ` Trond Myklebust
2015-12-28 15:53 ` Benjamin Coddington
2015-12-07 19:18 ` Jeff Layton
2015-12-07 16:26 ` [PATCH v2 03/10] NFS: Pass nfs_open_context instead of file to the lock procs Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 04/10] NFSv4: Pass nfs_open_context instead of nfs4_state to nfs4_proc_unlck() Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 05/10] lockd: Plumb nfs_open_context into nlm client unlock Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 06/10] lockd: Send the inode to nlmclnt_setlockargs() Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 07/10] lockd: do_vfs_lock() only needs the inode Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 08/10] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 09/10] NFS: Deferred unlocks - always unlock on FL_CLOSE Benjamin Coddington
2015-12-07 16:26 ` [PATCH v2 10/10] NFS: cleanup do_vfs_lock() Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20151207192222.GA7938@infradead.org \
--to=hch@infradead.org \
--cc=anna.schumaker@netapp.com \
--cc=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@primarydata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox