[PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

[PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

[Steve Dickson]

According to systemd.special(7) manpage:

rpcbind.target
    The portmapper/rpcbind pulls in this target and orders itself
    before it, to indicate its availability. systemd automatically
    adds dependencies of type After= for this target unit to
    all SysV init script service units with an LSB header
    referring to the "$portmap" facility.

Signed-off-by: Steve Dickson <steved@redhat.com>
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
---
 systemd/rpcbind.service.in | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
index f8cfa9f..9dbc82c 100644
--- a/systemd/rpcbind.service.in
+++ b/systemd/rpcbind.service.in
@@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
 
 # Make sure we use the IP addresses listed for
 # rpcbind.socket, no matter how this unit is started.
-Wants=rpcbind.socket
-After=rpcbind.socket
+Requires=rpcbind.socket
+Before=rpcbind.target
 
 [Service]
 Type=notify
-- 
2.14.3

Re: [systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

[Lennart Poettering]

On Fr, 15.12.17 08:00, Steve Dickson (steved@redhat.com) wrote:

> According to systemd.special(7) manpage:
> 
> rpcbind.target
>     The portmapper/rpcbind pulls in this target and orders itself
>     before it, to indicate its availability. systemd automatically
>     adds dependencies of type After= for this target unit to
>     all SysV init script service units with an LSB header
>     referring to the "$portmap" facility.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
> ---
>  systemd/rpcbind.service.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
> index f8cfa9f..9dbc82c 100644
> --- a/systemd/rpcbind.service.in
> +++ b/systemd/rpcbind.service.in
> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>  
>  # Make sure we use the IP addresses listed for
>  # rpcbind.socket, no matter how this unit is started.
> -Wants=rpcbind.socket
> -After=rpcbind.socket
> +Requires=rpcbind.socket
> +Before=rpcbind.target

You should still pull in rpcbind.target as the man page
says. i.e. "Wants=rpcbind.target" really should be there.

Lennart

-- 
Lennart Poettering, Red Hat

Re: [systemd-devel] [PATCH][V2] rpcbind.service: Not pulling the rpcbind.target

[Steve Dickson]

On 12/15/2017 09:52 AM, Lennart Poettering wrote:
> On Fr, 15.12.17 08:00, Steve Dickson (steved@redhat.com) wrote:
> 
>> According to systemd.special(7) manpage:
>>
>> rpcbind.target
>>     The portmapper/rpcbind pulls in this target and orders itself
>>     before it, to indicate its availability. systemd automatically
>>     adds dependencies of type After= for this target unit to
>>     all SysV init script service units with an LSB header
>>     referring to the "$portmap" facility.
>>
>> Signed-off-by: Steve Dickson <steved@redhat.com>
>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1431574
>> ---
>>  systemd/rpcbind.service.in | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/systemd/rpcbind.service.in b/systemd/rpcbind.service.in
>> index f8cfa9f..9dbc82c 100644
>> --- a/systemd/rpcbind.service.in
>> +++ b/systemd/rpcbind.service.in
>> @@ -6,8 +6,8 @@ RequiresMountsFor=@statedir@
>>  
>>  # Make sure we use the IP addresses listed for
>>  # rpcbind.socket, no matter how this unit is started.
>> -Wants=rpcbind.socket
>> -After=rpcbind.socket
>> +Requires=rpcbind.socket
>> +Before=rpcbind.target
> 
> You should still pull in rpcbind.target as the man page
> says. i.e. "Wants=rpcbind.target" really should be there.
Duly noted... and changed!

thanks!

steved.
> 
> Lennart
>