public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] NFSD remove OP_CACHEME from 4.2 op_flags
@ 2018-12-04 19:09 Olga Kornievskaia
  2018-12-14 14:45 ` J. Bruce Fields
  0 siblings, 1 reply; 2+ messages in thread
From: Olga Kornievskaia @ 2018-12-04 19:09 UTC (permalink / raw)
  To: bfields; +Cc: linux-nfs

From: Olga Kornievskaia <kolga@netapp.com>

OP_CACHEME is only for the 4.0 operations.

Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
---
 fs/nfsd/nfs4proc.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
index 238c4b7..60c4650 100644
--- a/fs/nfsd/nfs4proc.c
+++ b/fs/nfsd/nfs4proc.c
@@ -3010,25 +3010,25 @@ static inline u32 nfsd4_seek_rsize(struct svc_rqst *rqstp, struct nfsd4_op *op)
 	/* NFSv4.2 operations */
 	[OP_ALLOCATE] = {
 		.op_func = nfsd4_allocate,
-		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
+		.op_flags = OP_MODIFIES_SOMETHING,
 		.op_name = "OP_ALLOCATE",
 		.op_rsize_bop = nfsd4_only_status_rsize,
 	},
 	[OP_DEALLOCATE] = {
 		.op_func = nfsd4_deallocate,
-		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
+		.op_flags = OP_MODIFIES_SOMETHING,
 		.op_name = "OP_DEALLOCATE",
 		.op_rsize_bop = nfsd4_only_status_rsize,
 	},
 	[OP_CLONE] = {
 		.op_func = nfsd4_clone,
-		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
+		.op_flags = OP_MODIFIES_SOMETHING,
 		.op_name = "OP_CLONE",
 		.op_rsize_bop = nfsd4_only_status_rsize,
 	},
 	[OP_COPY] = {
 		.op_func = nfsd4_copy,
-		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
+		.op_flags = OP_MODIFIES_SOMETHING,
 		.op_name = "OP_COPY",
 		.op_rsize_bop = nfsd4_copy_rsize,
 	},
-- 
1.8.3.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] NFSD remove OP_CACHEME from 4.2 op_flags
  2018-12-04 19:09 [PATCH 1/1] NFSD remove OP_CACHEME from 4.2 op_flags Olga Kornievskaia
@ 2018-12-14 14:45 ` J. Bruce Fields
  0 siblings, 0 replies; 2+ messages in thread
From: J. Bruce Fields @ 2018-12-14 14:45 UTC (permalink / raw)
  To: Olga Kornievskaia; +Cc: bfields, linux-nfs

Thanks, applying for 4.21.--b.

On Tue, Dec 04, 2018 at 02:09:21PM -0500, Olga Kornievskaia wrote:
> From: Olga Kornievskaia <kolga@netapp.com>
> 
> OP_CACHEME is only for the 4.0 operations.
> 
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfsd/nfs4proc.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4proc.c b/fs/nfsd/nfs4proc.c
> index 238c4b7..60c4650 100644
> --- a/fs/nfsd/nfs4proc.c
> +++ b/fs/nfsd/nfs4proc.c
> @@ -3010,25 +3010,25 @@ static inline u32 nfsd4_seek_rsize(struct svc_rqst *rqstp, struct nfsd4_op *op)
>  	/* NFSv4.2 operations */
>  	[OP_ALLOCATE] = {
>  		.op_func = nfsd4_allocate,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_ALLOCATE",
>  		.op_rsize_bop = nfsd4_only_status_rsize,
>  	},
>  	[OP_DEALLOCATE] = {
>  		.op_func = nfsd4_deallocate,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_DEALLOCATE",
>  		.op_rsize_bop = nfsd4_only_status_rsize,
>  	},
>  	[OP_CLONE] = {
>  		.op_func = nfsd4_clone,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_CLONE",
>  		.op_rsize_bop = nfsd4_only_status_rsize,
>  	},
>  	[OP_COPY] = {
>  		.op_func = nfsd4_copy,
> -		.op_flags = OP_MODIFIES_SOMETHING | OP_CACHEME,
> +		.op_flags = OP_MODIFIES_SOMETHING,
>  		.op_name = "OP_COPY",
>  		.op_rsize_bop = nfsd4_copy_rsize,
>  	},
> -- 
> 1.8.3.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-12-14 14:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-12-04 19:09 [PATCH 1/1] NFSD remove OP_CACHEME from 4.2 op_flags Olga Kornievskaia
2018-12-14 14:45 ` J. Bruce Fields

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox