From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jens Axboe <axboe@kernel.dk>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Trond Myklebust <trondmy@gmail.com>,
NFS Mailing List <linux-nfs@vger.kernel.org>
Cc: Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Ming Lei <ming.lei@redhat.com>
Subject: linux-next: build failure after merge of the block tree
Date: Wed, 16 Jan 2019 13:35:52 +1100 [thread overview]
Message-ID: <20190116133552.37436b9c@canb.auug.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 1724 bytes --]
Hi all,
After merging the block tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
net/sunrpc/xprtsock.c: In function 'xs_flush_bvec':
net/sunrpc/xprtsock.c:390:2: error: implicit declaration of function 'for_each_bvec'; did you mean 'for_each_net'? [-Werror=implicit-function-declaration]
for_each_bvec(bv, bvec, bi, bi)
^~~~~~~~~~~~~
for_each_net
net/sunrpc/xprtsock.c:390:33: error: expected ';' before 'flush_dcache_page'
for_each_bvec(bv, bvec, bi, bi)
^
;
flush_dcache_page(bv.bv_page);
~~~~~~~~~~~~~~~~~
Caused by commit
f3effe4c1240 ("block: rename bvec helpers")
interacting with commit
6a829eb8619f ("SUNRPC: Fix TCP receive code on archs with flush_dcache_page()")
from the nfs-anna tree.
[I love API changes :-(]
I have applied the following merge fix patch:
From: Stephen Rothwell <sfr@canb.auug.org.au>
Date: Wed, 16 Jan 2019 13:32:59 +1100
Subject: [PATCH] SUNRPC: merge fix for "block: rename bvec helpers"
Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
---
net/sunrpc/xprtsock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c
index 7754aa3e434f..47f29cc23f27 100644
--- a/net/sunrpc/xprtsock.c
+++ b/net/sunrpc/xprtsock.c
@@ -387,7 +387,7 @@ xs_flush_bvec(const struct bio_vec *bvec, size_t count, size_t seek)
struct bio_vec bv;
bvec_iter_advance(bvec, &bi, seek & PAGE_MASK);
- for_each_bvec(bv, bvec, bi, bi)
+ for_each_segment(bv, bvec, bi, bi)
flush_dcache_page(bv.bv_page);
}
#else
--
2.20.1
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next reply other threads:[~2019-01-16 2:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-16 2:35 Stephen Rothwell [this message]
2019-01-16 2:48 ` linux-next: build failure after merge of the block tree Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116133552.37436b9c@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=Anna.Schumaker@Netapp.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=trondmy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox