From: "J. Bruce Fields" <bfields@fieldses.org>
To: Scott Mayhew <smayhew@redhat.com>
Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: Re: [PATCH RFC v3 0/5] un-deprecate nfsdcld
Date: Fri, 5 Apr 2019 16:43:34 -0400 [thread overview]
Message-ID: <20190405204334.GD8397@fieldses.org> (raw)
In-Reply-To: <20190329121609.GA3659@coeurl.usersys.redhat.com>
On Fri, Mar 29, 2019 at 08:16:09AM -0400, Scott Mayhew wrote:
> On Thu, 28 Mar 2019, J. Bruce Fields wrote:
> > Thanks! It looks good to me on a first skim, but I probably won't get a
> > proper look at it till next week.
> >
> > You say "RFC"--are there still known issue that you're working on?
>
> No, I just added RFC because of the new stuff I added for handling the
> legacy records. Plus I wasn't sure if you would have a problem with the
> server not lifting the grace period early if there were legacy records.
> I could do it if I moved some code out of nfs4recover.c but I chose not
> to since it should really be a one-time thing and the original legacy
> tracking didn't lift the grace period early anyway.
Yeah, I don't think that case is worth spending time optimizing.
The kernel patches look OK to me. I'm inclined to target them for the
next merge window (5.2). If Jeff has the time to take a look, it'd also
be good to know if he has any more concerns.
--b.
prev parent reply other threads:[~2019-04-05 20:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 22:06 [PATCH RFC v3 0/5] un-deprecate nfsdcld Scott Mayhew
2019-03-26 22:06 ` [PATCH RFC v3 1/5] nfsd: make nfs4_client_reclaim use an xdr_netobj instead of a fixed char array Scott Mayhew
2019-03-26 22:06 ` [PATCH RFC v3 2/5] nfsd: un-deprecate nfsdcld Scott Mayhew
2019-04-05 18:54 ` J. Bruce Fields
2019-04-05 19:26 ` Scott Mayhew
2019-04-05 20:11 ` J. Bruce Fields
2019-03-26 22:06 ` [PATCH RFC v3 3/5] nfsd: keep a tally of RECLAIM_COMPLETE operations when using nfsdcld Scott Mayhew
2019-03-26 22:06 ` [PATCH RFC v3 4/5] nfsd: re-order client tracking method selection Scott Mayhew
2019-04-05 20:40 ` J. Bruce Fields
2019-03-26 22:06 ` [PATCH RFC v3 5/5] nfsd: handle legacy client tracking records sent by nfsdcld Scott Mayhew
2019-03-28 21:17 ` [PATCH RFC v3 0/5] un-deprecate nfsdcld J. Bruce Fields
2019-03-29 12:16 ` Scott Mayhew
2019-04-05 20:43 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405204334.GD8397@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=smayhew@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox