public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Ben Dooks <ben.dooks@codethink.co.uk>
Cc: linux-kernel@lists.codethink.co.uk,
	Trond Myklebust <trond.myklebust@hammerspace.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFSv4: add declaration of current_stateid
Date: Tue, 15 Oct 2019 09:31:36 -0700	[thread overview]
Message-ID: <20191015163136.GA11160@infradead.org> (raw)
In-Reply-To: <20191015121953.14905-1-ben.dooks@codethink.co.uk>

On Tue, Oct 15, 2019 at 01:19:53PM +0100, Ben Dooks wrote:
> The current_stateid is exported from nfs4state.c but not
> declared in any of the headers. Add to nfs4_fs.h to
> remove the following warning:

I think you also need to remove the extern in pnfs.c as well.

Also nfs4_stateid_is_current has a local variable with the same name,
so you might want to rename that so that we don't get symbol shadowing
warnings.

  reply	other threads:[~2019-10-15 16:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-15 12:19 [PATCH] NFSv4: add declaration of current_stateid Ben Dooks
2019-10-15 16:31 ` Christoph Hellwig [this message]
2019-10-16 16:27   ` Ben Dooks

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191015163136.GA11160@infradead.org \
    --to=hch@infradead.org \
    --cc=anna.schumaker@netapp.com \
    --cc=ben.dooks@codethink.co.uk \
    --cc=linux-kernel@lists.codethink.co.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox