* [PATCH 1/1] nfsd: remove read permission bit for ctl sysctl
@ 2020-03-13 12:39 Petr Vorel
2020-03-13 14:41 ` Chuck Lever
0 siblings, 1 reply; 3+ messages in thread
From: Petr Vorel @ 2020-03-13 12:39 UTC (permalink / raw)
To: linux-nfs; +Cc: Petr Vorel, J . Bruce Fields, Chuck Lever
It's meant to be read only.
Fixes: 89c905beccbb ("nfsd: allow forced expiration of NFSv4 clients")
Signed-off-by: Petr Vorel <pvorel@suse.cz>
---
Hi,
does not really fix anything, it's just confusing to have read
permission bit when not used.
Kind regards,
Petr
fs/nfsd/nfs4state.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 65cfe9ab47be..475ece438cfc 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -2636,7 +2636,7 @@ static const struct file_operations client_ctl_fops = {
static const struct tree_descr client_files[] = {
[0] = {"info", &client_info_fops, S_IRUSR},
[1] = {"states", &client_states_fops, S_IRUSR},
- [2] = {"ctl", &client_ctl_fops, S_IRUSR|S_IWUSR},
+ [2] = {"ctl", &client_ctl_fops, S_IWUSR},
[3] = {""},
};
--
2.16.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nfsd: remove read permission bit for ctl sysctl
2020-03-13 12:39 [PATCH 1/1] nfsd: remove read permission bit for ctl sysctl Petr Vorel
@ 2020-03-13 14:41 ` Chuck Lever
2020-03-13 20:08 ` Petr Vorel
0 siblings, 1 reply; 3+ messages in thread
From: Chuck Lever @ 2020-03-13 14:41 UTC (permalink / raw)
To: Petr Vorel; +Cc: Linux NFS Mailing List, Bruce Fields
> On Mar 13, 2020, at 8:39 AM, Petr Vorel <pvorel@suse.cz> wrote:
>
> It's meant to be read only.
>
> Fixes: 89c905beccbb ("nfsd: allow forced expiration of NFSv4 clients")
>
> Signed-off-by: Petr Vorel <pvorel@suse.cz>
> ---
> Hi,
>
> does not really fix anything, it's just confusing to have read
> permission bit when not used.
Hi Petr, applied to nfsd-5.7-testing, with the patch description corrected
to read:
"It's meant to be write-only."
> Kind regards,
> Petr
>
> fs/nfsd/nfs4state.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 65cfe9ab47be..475ece438cfc 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -2636,7 +2636,7 @@ static const struct file_operations client_ctl_fops = {
> static const struct tree_descr client_files[] = {
> [0] = {"info", &client_info_fops, S_IRUSR},
> [1] = {"states", &client_states_fops, S_IRUSR},
> - [2] = {"ctl", &client_ctl_fops, S_IRUSR|S_IWUSR},
> + [2] = {"ctl", &client_ctl_fops, S_IWUSR},
> [3] = {""},
> };
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] nfsd: remove read permission bit for ctl sysctl
2020-03-13 14:41 ` Chuck Lever
@ 2020-03-13 20:08 ` Petr Vorel
0 siblings, 0 replies; 3+ messages in thread
From: Petr Vorel @ 2020-03-13 20:08 UTC (permalink / raw)
To: Chuck Lever; +Cc: Petr Vorel, Linux NFS Mailing List, Bruce Fields
> Hi Petr, applied to nfsd-5.7-testing, with the patch description corrected
> to read:
>
> "It's meant to be write-only."
Thanks, Chuck!
Kind regards,
Petr
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-03-13 20:08 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-13 12:39 [PATCH 1/1] nfsd: remove read permission bit for ctl sysctl Petr Vorel
2020-03-13 14:41 ` Chuck Lever
2020-03-13 20:08 ` Petr Vorel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox