* [PATCH] nfsd: Fix message level for normal termination
@ 2020-11-27 2:44 kazuo ito
2020-11-27 3:56 ` Chuck Lever
0 siblings, 1 reply; 4+ messages in thread
From: kazuo ito @ 2020-11-27 2:44 UTC (permalink / raw)
To: J. Bruce Fields, Chuck Lever, linux-nfs; +Cc: kazuo ito, Jeff Layton
A warning message from nfsd terminating normally
can confuse system adminstrators or monitoring software.
Though it's not exactly fair to pin-point a commit where it
originated, the current form in the current place started
to appear in:
Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
Signed-off-by: kazuo ito <kzpn200@gmail.com>
---
fs/nfsd/nfssvc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index f7f6473578af..b08cccb71787 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -527,8 +527,8 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
return;
nfsd_shutdown_net(net);
- printk(KERN_WARNING "nfsd: last server has exited, flushing export "
- "cache\n");
+ printk(KERN_INFO "nfsd: last server has exited, flushing export "
+ "cache\n");
nfsd_export_flush(net);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nfsd: Fix message level for normal termination
2020-11-27 2:44 [PATCH] nfsd: Fix message level for normal termination kazuo ito
@ 2020-11-27 3:56 ` Chuck Lever
2020-11-27 6:26 ` kazuo ito
0 siblings, 1 reply; 4+ messages in thread
From: Chuck Lever @ 2020-11-27 3:56 UTC (permalink / raw)
To: kazuo ito; +Cc: J. Bruce Fields, linux-nfs, Jeff Layton
> On Nov 26, 2020, at 9:46 PM, kazuo ito <kzpn200@gmail.com> wrote:
>
> A warning message from nfsd terminating normally
> can confuse system adminstrators or monitoring software.
>
> Though it's not exactly fair to pin-point a commit where it
> originated, the current form in the current place started
> to appear in:
>
> Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
> Signed-off-by: kazuo ito <kzpn200@gmail.com>
> ---
> fs/nfsd/nfssvc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index f7f6473578af..b08cccb71787 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -527,8 +527,8 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
> return;
>
> nfsd_shutdown_net(net);
> - printk(KERN_WARNING "nfsd: last server has exited, flushing export "
> - "cache\n");
> + printk(KERN_INFO "nfsd: last server has exited, flushing export "
> + "cache\n");
pr_info(), please! And see if it will fit on one line.
> nfsd_export_flush(net);
> }
>
> --
> 2.20.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] nfsd: Fix message level for normal termination
2020-11-27 3:56 ` Chuck Lever
@ 2020-11-27 6:26 ` kazuo ito
2020-11-27 17:11 ` Chuck Lever
0 siblings, 1 reply; 4+ messages in thread
From: kazuo ito @ 2020-11-27 6:26 UTC (permalink / raw)
To: linux-nfs, J. Bruce Fields, Chuck Lever; +Cc: kazuo ito
The warning message from nfsd terminating normally
can confuse system adminstrators or monitoring software.
Though it's not exactly fair to pin-point a commit where it
originated, the current form in the current place started
to appear in:
Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
Signed-off-by: kazuo ito <kzpn200@gmail.com>
---
fs/nfsd/nfssvc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
index 27b1ad136150..9323e30a7eaf 100644
--- a/fs/nfsd/nfssvc.c
+++ b/fs/nfsd/nfssvc.c
@@ -527,8 +527,7 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
return;
nfsd_shutdown_net(net);
- printk(KERN_WARNING "nfsd: last server has exited, flushing export "
- "cache\n");
+ pr_info("nfsd: last server has exited, flushing export cache\n");
nfsd_export_flush(net);
}
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] nfsd: Fix message level for normal termination
2020-11-27 6:26 ` kazuo ito
@ 2020-11-27 17:11 ` Chuck Lever
0 siblings, 0 replies; 4+ messages in thread
From: Chuck Lever @ 2020-11-27 17:11 UTC (permalink / raw)
To: kazuo ito; +Cc: Linux NFS Mailing List, Bruce Fields
> On Nov 27, 2020, at 1:26 AM, kazuo ito <kzpn200@gmail.com> wrote:
>
> The warning message from nfsd terminating normally
> can confuse system adminstrators or monitoring software.
>
> Though it's not exactly fair to pin-point a commit where it
> originated, the current form in the current place started
> to appear in:
>
> Fixes: e096bbc6488d ("knfsd: remove special handling for SIGHUP")
> Signed-off-by: kazuo ito <kzpn200@gmail.com>
> ---
> fs/nfsd/nfssvc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfssvc.c b/fs/nfsd/nfssvc.c
> index 27b1ad136150..9323e30a7eaf 100644
> --- a/fs/nfsd/nfssvc.c
> +++ b/fs/nfsd/nfssvc.c
> @@ -527,8 +527,7 @@ static void nfsd_last_thread(struct svc_serv *serv, struct net *net)
> return;
>
> nfsd_shutdown_net(net);
> - printk(KERN_WARNING "nfsd: last server has exited, flushing export "
> - "cache\n");
> + pr_info("nfsd: last server has exited, flushing export cache\n");
> nfsd_export_flush(net);
> }
Thanks.
Applied internally for the next full merge window. It should
appear soon in the cel-next topic branch at:
git://git.linux-nfs.org/projects/cel/cel-2.6.git
or
https://git.linux-nfs.org/?p=cel/cel-2.6.git;a=summary
--
Chuck Lever
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-11-27 17:11 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-27 2:44 [PATCH] nfsd: Fix message level for normal termination kazuo ito
2020-11-27 3:56 ` Chuck Lever
2020-11-27 6:26 ` kazuo ito
2020-11-27 17:11 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox