From: "J. Bruce Fields" <bfields@fieldses.org>
To: Thomas Haynes <loghyr@gmail.com>
Cc: Bruce Fields <bfields@redhat.com>,
Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [pynfs 03/10] Close the file for SEQ10b
Date: Sun, 20 Dec 2020 21:46:19 -0500 [thread overview]
Message-ID: <20201221024619.GE24298@fieldses.org> (raw)
In-Reply-To: <C99E0C08-FEC2-4F5A-9467-7B96CA8E51F2@gmail.com>
On Sun, Dec 20, 2020 at 06:42:55PM -0800, Thomas Haynes wrote:
>
>
> > On Dec 18, 2020, at 8:43 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
> >
> > On Wed, Dec 16, 2020 at 04:35:09PM -0800, Tom Haynes wrote:
> >>
> >> close_file(sess1, fh, stateid=stateid)
> >>
> >> + # Cleanup
> >> + res = sess1.compound([op.putfh(fh), op.close(0, stateid)])
> >> + check(res)
> >> +
> >
> > This is giving me:
> >
> > SEQ10b st_sequence.testReplayCache007 : FAILURE
> > OP_CLOSE should return NFS4_OK, instead got
> > NFS4ERR_BAD_STATEID
> >
> > probably because the file was already closed just above. I'm not sure
> > whta was intended here. Reverting for now.
> >
> > —b
>
> Ahh, that close is not there in the branch we have internally. And since git took the change, I thought it was still good.
>
> Backing out is cool.
Oh, I see what happened, thanks for following up.
--b.
next prev parent reply other threads:[~2020-12-21 2:56 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-17 0:35 [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN Tom Haynes
2020-12-17 0:35 ` [pynfs 01/10] st_flex.py - Added tests for LAYOUTRETURN with errors Tom Haynes
2020-12-17 0:35 ` [pynfs 02/10] st_flex.py - Fixed flag names Tom Haynes
2020-12-17 0:35 ` [pynfs 03/10] Close the file for SEQ10b Tom Haynes
2020-12-18 16:43 ` J. Bruce Fields
2020-12-21 2:42 ` Thomas Haynes
2020-12-21 2:46 ` J. Bruce Fields [this message]
2020-12-17 0:35 ` [pynfs 04/10] flexfiles: Fix up the layout error handling to reflect the previous error Tom Haynes
2020-12-17 0:35 ` [pynfs 05/10] Fix testFlexLayoutOldSeqid Tom Haynes
2020-12-17 0:35 ` [pynfs 06/10] st_flex: Reduce the layoutstats period to make tests finish in a sane time Tom Haynes
2020-12-17 0:35 ` [pynfs 07/10] st_flex: Fix up test names Tom Haynes
2020-12-17 0:35 ` [pynfs 08/10] st_flex: Only do 100 layoutget/return in loop Tom Haynes
2020-12-17 0:35 ` [pynfs 09/10] st_flex: We can't return the layout without a layout stateid Tom Haynes
2020-12-17 0:35 ` [pynfs 10/10] st_flex: Fixup check for error in layoutget_return() Tom Haynes
2020-12-18 14:46 ` [pynfs 00/10] Misc Fixes, primarily LAYOUTRETURN J. Bruce Fields
2020-12-18 16:23 ` Mkrtchyan, Tigran
2020-12-18 16:37 ` J. Bruce Fields
2020-12-18 16:38 ` Thomas Haynes
2020-12-18 16:50 ` Mkrtchyan, Tigran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201221024619.GE24298@fieldses.org \
--to=bfields@fieldses.org \
--cc=bfields@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=loghyr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox