Linux NFS development
 help / color / mirror / Atom feed
From: trondmy@kernel.org
To: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 5/5] NFS: Fix the verifier for case sensitive filesystem in nfs_atomic_open()
Date: Fri, 17 Dec 2021 15:36:58 -0500	[thread overview]
Message-ID: <20211217203658.439352-6-trondmy@kernel.org> (raw)
In-Reply-To: <20211217203658.439352-5-trondmy@kernel.org>

From: Trond Myklebust <trond.myklebust@hammerspace.com>

Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
---
 fs/nfs/dir.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
index a490704e10ed..9432820ce21c 100644
--- a/fs/nfs/dir.c
+++ b/fs/nfs/dir.c
@@ -1888,6 +1888,7 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry,
 	struct iattr attr = { .ia_valid = ATTR_OPEN };
 	struct inode *inode;
 	unsigned int lookup_flags = 0;
+	unsigned long dir_verifier;
 	bool switched = false;
 	int created = 0;
 	int err;
@@ -1961,7 +1962,11 @@ int nfs_atomic_open(struct inode *dir, struct dentry *dentry,
 		switch (err) {
 		case -ENOENT:
 			d_splice_alias(NULL, dentry);
-			nfs_set_verifier(dentry, nfs_save_change_attribute(dir));
+			if (nfs_server_capable(dir, NFS_CAP_CASE_INSENSITIVE))
+				dir_verifier = inode_peek_iversion_raw(dir);
+			else
+				dir_verifier = nfs_save_change_attribute(dir);
+			nfs_set_verifier(dentry, dir_verifier);
 			break;
 		case -EISDIR:
 		case -ENOTDIR:
-- 
2.33.1


  reply	other threads:[~2021-12-17 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-17 20:36 [PATCH 0/5] Support case insensitive filesystems in NFSv4 trondmy
2021-12-17 20:36 ` [PATCH 1/5] NFSv4: Add some support for case insensitive filesystems trondmy
2021-12-17 20:36   ` [PATCH 2/5] NFSv4: Just don't cache negative dentries on case insensitive servers trondmy
2021-12-17 20:36     ` [PATCH 3/5] NFS: Invalidate negative dentries on all case insensitive directory changes trondmy
2021-12-17 20:36       ` [PATCH 4/5] NFS: Add a helper to remove case-insensitive aliases trondmy
2021-12-17 20:36         ` trondmy [this message]
2022-01-03 20:08 ` [PATCH 0/5] Support case insensitive filesystems in NFSv4 J. Bruce Fields
2022-01-03 20:11   ` Trond Myklebust
2022-01-03 21:46     ` bfields
2022-01-03 22:13       ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20211217203658.439352-6-trondmy@kernel.org \
    --to=trondmy@kernel.org \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox