From: "bfields@fieldses.org" <bfields@fieldses.org>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "trondmy@kernel.org" <trondmy@kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"anna.schumaker@netapp.com" <anna.schumaker@netapp.com>
Subject: Re: [PATCH 0/5] Support case insensitive filesystems in NFSv4
Date: Mon, 3 Jan 2022 16:46:28 -0500 [thread overview]
Message-ID: <20220103214628.GM21514@fieldses.org> (raw)
In-Reply-To: <cb2b119e0c95c8d9d783d8b28c7f2bc7973f7598.camel@hammerspace.com>
On Mon, Jan 03, 2022 at 08:11:57PM +0000, Trond Myklebust wrote:
> On Mon, 2022-01-03 at 15:08 -0500, J. Bruce Fields wrote:
> > On Fri, Dec 17, 2021 at 03:36:53PM -0500, trondmy@kernel.org wrote:
> > > From: Trond Myklebust <trond.myklebust@hammerspace.com>
> > >
> > > Add support for detecting an export of a case insensitive
> > > filesystem in
> > > NFSv4. If that is the case, then we need to adjust the dentry
> > > caching
> > > and invalidation rules to ensure that we don't inadvertently end up
> > > caching other case folded aliases after an operation that results
> > > in a
> > > directory entry name change.
> >
> > What server and configuration are you testing this against?
>
> Ours.
You mean, hammerspace?
> Why?
Partly just curiousity. Partly I thought we'd previously been trying to
add features on server and client side together when it makes sense, if
only to make it possible to test without access to proprietary software.
I don't actually have a strong opinion on the policy, but if this *is* a
change in policy then it's worth mentioning.
There should be other exportable filesystems supporting those attributes
so the work to export them on the server side wouldn't be a whole lot.
(But I can't volunteer.)
--b.
> > >
> > > Trond Myklebust (5):
> > > NFSv4: Add some support for case insensitive filesystems
> > > NFSv4: Just don't cache negative dentries on case insensitive
> > > servers
> > > NFS: Invalidate negative dentries on all case insensitive
> > > directory
> > > changes
> > > NFS: Add a helper to remove case-insensitive aliases
> > > NFS: Fix the verifier for case sensitive filesystem in
> > > nfs_atomic_open()
> > >
> > > fs/nfs/dir.c | 41 +++++++++++++++++++++++++++++++++--
> > > ----
> > > fs/nfs/internal.h | 1 +
> > > fs/nfs/nfs4proc.c | 13 +++++++++++--
> > > fs/nfs/nfs4xdr.c | 40
> > > ++++++++++++++++++++++++++++++++++++++
> > > include/linux/nfs_fs_sb.h | 2 ++
> > > include/linux/nfs_xdr.h | 2 ++
> > > 6 files changed, 91 insertions(+), 8 deletions(-)
> > >
> > > --
> > > 2.33.1
>
> --
> Trond Myklebust
> Linux NFS client maintainer, Hammerspace
> trond.myklebust@hammerspace.com
>
>
next prev parent reply other threads:[~2022-01-03 21:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 20:36 [PATCH 0/5] Support case insensitive filesystems in NFSv4 trondmy
2021-12-17 20:36 ` [PATCH 1/5] NFSv4: Add some support for case insensitive filesystems trondmy
2021-12-17 20:36 ` [PATCH 2/5] NFSv4: Just don't cache negative dentries on case insensitive servers trondmy
2021-12-17 20:36 ` [PATCH 3/5] NFS: Invalidate negative dentries on all case insensitive directory changes trondmy
2021-12-17 20:36 ` [PATCH 4/5] NFS: Add a helper to remove case-insensitive aliases trondmy
2021-12-17 20:36 ` [PATCH 5/5] NFS: Fix the verifier for case sensitive filesystem in nfs_atomic_open() trondmy
2022-01-03 20:08 ` [PATCH 0/5] Support case insensitive filesystems in NFSv4 J. Bruce Fields
2022-01-03 20:11 ` Trond Myklebust
2022-01-03 21:46 ` bfields [this message]
2022-01-03 22:13 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220103214628.GM21514@fieldses.org \
--to=bfields@fieldses.org \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox