From: Dan Aloni <dan.aloni@vastdata.com>
To: trondmy@kernel.org
Cc: Anna Schumaker <Anna.Schumaker@netapp.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] NFS: Always provide aligned buffers to the RPC read layers
Date: Tue, 18 Jan 2022 21:26:27 +0200 [thread overview]
Message-ID: <20220118192627.tg4myc77nmbqm2np@gmail.com> (raw)
In-Reply-To: <20210827180056.610170-1-trondmy@kernel.org>
On Fri, Aug 27, 2021 at 02:00:56PM -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> Instead of messing around with XDR padding in the RDMA layer, we should
> just give the RPC layer an aligned buffer. Try to avoid creating extra
> RPC calls by aligning to the smaller value of ALIGN(len, rsize) and
> PAGE_SIZE.
I've bisected this change to be the cause of xfstests generic/525
getting stuck when tested against a standard Linux NFS server. It was
stuck in a repeated request loop in kernel mode, and killable.
I posted a patch with a full explanation in a reply.
--
Dan Aloni
next prev parent reply other threads:[~2022-01-18 19:26 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 18:00 [PATCH] NFS: Always provide aligned buffers to the RPC read layers trondmy
2022-01-18 19:26 ` Dan Aloni [this message]
2022-01-18 19:33 ` [PATCH] NFS: fix an infinite request retry in an off-by-one last page read Dan Aloni
2022-01-18 19:43 ` Trond Myklebust
2022-01-21 18:50 ` [PATCH] NFSD: trim reads past NFS_OFFSET_MAX Dan Aloni
2022-01-21 22:32 ` Chuck Lever III
2022-01-22 12:47 ` Dan Aloni
2022-01-22 17:05 ` Chuck Lever III
2022-01-22 18:27 ` Trond Myklebust
2022-01-22 20:15 ` Chuck Lever III
2022-01-22 20:30 ` Trond Myklebust
2022-01-23 17:35 ` Chuck Lever III
2022-01-22 19:01 ` Dan Aloni
2022-01-22 20:33 ` Chuck Lever III
2022-01-22 12:49 ` [PATCH v2] NFSD: trim reads past NFS_OFFSET_MAX and fix NFSv3 check Dan Aloni
2022-01-22 17:37 ` Chuck Lever III
2022-01-23 6:29 ` Dan Aloni
2022-01-23 9:50 ` [PATCH v3] " Dan Aloni
2022-01-23 15:29 ` Trond Myklebust
2022-01-23 17:03 ` Chuck Lever III
2022-01-26 16:23 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220118192627.tg4myc77nmbqm2np@gmail.com \
--to=dan.aloni@vastdata.com \
--cc=Anna.Schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox