public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] NFS: dprintk() should not print negative inode number
@ 2022-11-22 13:28 Donglin Peng
  0 siblings, 0 replies; only message in thread
From: Donglin Peng @ 2022-11-22 13:28 UTC (permalink / raw)
  To: trond.myklebust, anna; +Cc: linux-kernel, linux-nfs, Donglin Peng

The type of the i_ino member of the inode structure is unsigned long.
There are some occurrences where dprintk() outputs a negative inode
number.This leads to confusion and more difficult to read debugging.

Fixes: 9e6e70f8d8b6 ("NFSv4: Support NFSv4 optional attributes in the struct nfs_fattr")
Signed-off-by: Donglin Peng <dolinux.peng@gmail.com>
---
 fs/nfs/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 6b2cfa59a1a2..53d8704e07c5 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -2081,7 +2081,7 @@ static int nfs_update_inode(struct inode *inode, struct nfs_fattr *fattr)
 				if (S_ISDIR(inode->i_mode))
 					nfs_force_lookup_revalidate(inode);
 				attr_changed = true;
-				dprintk("NFS: change_attr change on server for file %s/%ld\n",
+				dprintk("NFS: change_attr change on server for file %s/%lu\n",
 						inode->i_sb->s_id,
 						inode->i_ino);
 			} else if (!have_delegation)
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-11-22 13:28 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-22 13:28 [PATCH] NFS: dprintk() should not print negative inode number Donglin Peng

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox