From: Jeff Layton <jlayton@kernel.org>
To: bfields@fieldses.org, dai.ngo@oracle.com
Cc: linux-nfs@vger.kernel.org
Subject: [pynfs RFC PATCH] testserver.py: special-case the "all" flag
Date: Wed, 22 Feb 2023 13:20:43 -0500 [thread overview]
Message-ID: <20230222182043.155712-1-jlayton@kernel.org> (raw)
The READMEs for v4.0 and v4.1 are inconsistent here. For v4.0, the "all"
flag is supposed to run all of the "standard" tests. For v4.1 "all" is
documented to run all of the tests, but it actually doesn't since not
every tests has "all" in its FLAGS: field.
I move that we change this. If I say that I want to run "all", then I
really do want to run _all_ of the tests. Ensure that every test has the
"all" flag set.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
nfs4.1/testmod.py | 2 ++
1 file changed, 2 insertions(+)
If this is unacceptable, then an alternative could be to add a new
(similarly special-cased) "everything" flag.
diff --git a/nfs4.1/testmod.py b/nfs4.1/testmod.py
index 11e759d673fd..7b3bac543084 100644
--- a/nfs4.1/testmod.py
+++ b/nfs4.1/testmod.py
@@ -386,6 +386,8 @@ def createtests(testdir):
for t in tests:
## if not t.flags_list:
## raise RuntimeError("%s has no flags" % t.fullname)
+ if "all" not in t.flags_list:
+ t.flags_list.append("all")
for f in t.flags_list:
if f not in flag_dict:
flag_dict[f] = bit
--
2.39.2
next reply other threads:[~2023-02-22 18:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-22 18:20 Jeff Layton [this message]
2023-02-23 15:19 ` [pynfs RFC PATCH] testserver.py: special-case the "all" flag J. Bruce Fields
2023-02-23 16:20 ` Frank Filz
2023-02-23 16:21 ` Chuck Lever III
2023-02-23 16:26 ` Frank Filz
2023-02-23 17:10 ` Jeff Layton
2023-02-23 17:59 ` Mkrtchyan, Tigran
2023-02-23 22:41 ` Frank Filz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230222182043.155712-1-jlayton@kernel.org \
--to=jlayton@kernel.org \
--cc=bfields@fieldses.org \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox