Linux NFS development
 help / color / mirror / Atom feed
From: trondmy@kernel.org
To: Anna Schumaker <anna.schumaker@netapp.com>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v2 0/5] Fix O_DIRECT writeback error paths
Date: Mon,  4 Sep 2023 12:34:36 -0400	[thread overview]
Message-ID: <20230904163441.11950-1-trondmy@kernel.org> (raw)

From: Trond Myklebust <trond.myklebust@hammerspace.com>

In recent tests of the O_DIRECT code, a number of bugs were discovered
in the error codepaths, some of which were shown to result in data
corruption. The tests involved using pNFS flexfiles with 3-way
mirroring, and then shutting down one of the data servers. When the data
was later re-read from the server, it was shown to not match the
original data.

---
v1 - NFS: Fix error handling for O_DIRECT write scheduling
v2 - Fixes for incorrect commit info
     Fixes for O_DIRECT accounting
     O_DIRECT locking issues
     Fix write scheduling issues

Trond Myklebust (5):
  NFS: Fix error handling for O_DIRECT write scheduling
  NFS: Fix O_DIRECT locking issues
  NFS: More O_DIRECT accounting fixes for error paths
  NFS: Use the correct commit info in nfs_join_page_group()
  NFS: More fixes for nfs_direct_write_reschedule_io()

 fs/nfs/direct.c          | 134 +++++++++++++++++++++++++++------------
 fs/nfs/write.c           |  23 +++----
 include/linux/nfs_page.h |   4 +-
 3 files changed, 108 insertions(+), 53 deletions(-)

-- 
2.41.0


             reply	other threads:[~2023-09-04 16:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-04 16:34 trondmy [this message]
2023-09-04 16:34 ` [PATCH v2 1/5] NFS: Fix error handling for O_DIRECT write scheduling trondmy
2023-09-04 16:34   ` [PATCH v2 2/5] NFS: Fix O_DIRECT locking issues trondmy
2023-09-04 16:34     ` [PATCH v2 3/5] NFS: More O_DIRECT accounting fixes for error paths trondmy
2023-09-04 16:34       ` [PATCH v2 4/5] NFS: Use the correct commit info in nfs_join_page_group() trondmy
2023-09-04 16:34         ` [PATCH v2 5/5] NFS: More fixes for nfs_direct_write_reschedule_io() trondmy
2023-11-09 15:05   ` [PATCH v2 1/5] NFS: Fix error handling for O_DIRECT write scheduling Benjamin Coddington
2023-11-09 16:53     ` Trond Myklebust
2023-11-09 17:25       ` Benjamin Coddington
2023-11-15 13:04         ` Benjamin Coddington
2023-11-15 17:16           ` Trond Myklebust
2023-11-15 21:30             ` Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230904163441.11950-1-trondmy@kernel.org \
    --to=trondmy@kernel.org \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox