From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: linux-nfs@vger.kernel.org, anna.schumaker@netapp.com
Subject: Re: [PATCH v2 1/5] NFS: Fix error handling for O_DIRECT write scheduling
Date: Thu, 09 Nov 2023 12:25:10 -0500 [thread overview]
Message-ID: <4EBFA030-C144-4017-842F-B8D6B2ADC19A@redhat.com> (raw)
In-Reply-To: <44d134dd65a4c7194f5200a390e5229003ba4016.camel@hammerspace.com>
On 9 Nov 2023, at 11:53, Trond Myklebust wrote:
>
> Hi Ben,
>
> Relying on the value of dreq->bytes_left is just not a good idea, given
> that the layoutget request could end up returning NFS4ERR_DELAY.
>
> How about something like the following patch?
That looks promising! I think ->bytes_left could get dropped after this.
I'll send it through some testing and report back, thanks!
Ben
next prev parent reply other threads:[~2023-11-09 17:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-04 16:34 [PATCH v2 0/5] Fix O_DIRECT writeback error paths trondmy
2023-09-04 16:34 ` [PATCH v2 1/5] NFS: Fix error handling for O_DIRECT write scheduling trondmy
2023-09-04 16:34 ` [PATCH v2 2/5] NFS: Fix O_DIRECT locking issues trondmy
2023-09-04 16:34 ` [PATCH v2 3/5] NFS: More O_DIRECT accounting fixes for error paths trondmy
2023-09-04 16:34 ` [PATCH v2 4/5] NFS: Use the correct commit info in nfs_join_page_group() trondmy
2023-09-04 16:34 ` [PATCH v2 5/5] NFS: More fixes for nfs_direct_write_reschedule_io() trondmy
2023-11-09 15:05 ` [PATCH v2 1/5] NFS: Fix error handling for O_DIRECT write scheduling Benjamin Coddington
2023-11-09 16:53 ` Trond Myklebust
2023-11-09 17:25 ` Benjamin Coddington [this message]
2023-11-15 13:04 ` Benjamin Coddington
2023-11-15 17:16 ` Trond Myklebust
2023-11-15 21:30 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBFA030-C144-4017-842F-B8D6B2ADC19A@redhat.com \
--to=bcodding@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox