[PATCH] rpcb_clnt.c: memory leak in destroy_addr

[PATCH] rpcb_clnt.c: memory leak in destroy_addr

[Steve Dickson]

From: Herb Wartens <wartens2@llnl.gov>

Piece was dropped from original fix.

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2225226
Signed-off-by: Steve Dickson <steved@redhat.com>
---
 src/rpcb_clnt.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/rpcb_clnt.c b/src/rpcb_clnt.c
index 68fe69a..d909efc 100644
--- a/src/rpcb_clnt.c
+++ b/src/rpcb_clnt.c
@@ -121,6 +121,7 @@ destroy_addr(addr)
 			free(addr->ac_taddr->buf);
 			addr->ac_taddr->buf = NULL;
 		}
+		free(addr->ac_taddr);
 		addr->ac_taddr = NULL;
 	}
 	free(addr);
-- 
2.44.0

Re: [PATCH] rpcb_clnt.c: memory leak in destroy_addr

[Steve Dickson]

On 3/18/24 11:11 AM, Steve Dickson wrote:
> From: Herb Wartens <wartens2@llnl.gov>
> 
> Piece was dropped from original fix.
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2225226
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... (tag: libtirpc-1-3-5-rc3)

steved.

> ---
>   src/rpcb_clnt.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/src/rpcb_clnt.c b/src/rpcb_clnt.c
> index 68fe69a..d909efc 100644
> --- a/src/rpcb_clnt.c
> +++ b/src/rpcb_clnt.c
> @@ -121,6 +121,7 @@ destroy_addr(addr)
>   			free(addr->ac_taddr->buf);
>   			addr->ac_taddr->buf = NULL;
>   		}
> +		free(addr->ac_taddr);
>   		addr->ac_taddr = NULL;
>   	}
>   	free(addr);