Linux NFS development
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Trond Myklebust <trond.myklebust@hammerspace.com>
Cc: linux-nfs@vger.kernel.org, Neil Brown <neilb@suse.de>,
	Jan Kara <jack@suse.cz>
Subject: [PATCH 2/3] nfs: Properly initialize server->writeback
Date: Thu, 13 Jun 2024 10:28:18 +0200	[thread overview]
Message-ID: <20240613082821.849-2-jack@suse.cz> (raw)
In-Reply-To: <20240612153022.25454-1-jack@suse.cz>

Atomic types should better be initialized with atomic_long_set() instead
of relying on zeroing done by kzalloc(). Clean this up.

Signed-off-by: Jan Kara <jack@suse.cz>
---
 fs/nfs/client.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/nfs/client.c b/fs/nfs/client.c
index de77848ae654..3b252dceebf5 100644
--- a/fs/nfs/client.c
+++ b/fs/nfs/client.c
@@ -994,6 +994,8 @@ struct nfs_server *nfs_alloc_server(void)
 
 	server->change_attr_type = NFS4_CHANGE_TYPE_IS_UNDEFINED;
 
+	atomic_long_set(&server->writeback, 0);
+
 	ida_init(&server->openowner_id);
 	ida_init(&server->lockowner_id);
 	pnfs_init_server(server);
-- 
2.35.3


  parent reply	other threads:[~2024-06-13  8:28 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-13  8:28 [PATCH 0/3] nfs: Improve throughput for random buffered writes Jan Kara
2024-06-13  8:28 ` [PATCH 1/3] nfs: Drop pointless check from nfs_commit_release_pages() Jan Kara
2024-06-13  9:17   ` Sagi Grimberg
2024-06-13 19:55   ` Jeff Layton
2024-06-13  8:28 ` Jan Kara [this message]
2024-06-13  9:17   ` [PATCH 2/3] nfs: Properly initialize server->writeback Sagi Grimberg
2024-06-13 19:56   ` Jeff Layton
2024-06-14 11:33     ` Jan Kara
2024-06-13  8:28 ` [PATCH 3/3] nfs: Block on write congestion Jan Kara
2024-06-13  9:18   ` Sagi Grimberg
2024-06-13 20:04   ` Jeff Layton
2024-06-14 11:44     ` Jan Kara
2024-06-13 22:56   ` NeilBrown
2024-06-14 11:57     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240613082821.849-2-jack@suse.cz \
    --to=jack@suse.cz \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox