public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trondmy@kernel.org>, Anna Schumaker <anna@kernel.org>
Cc: linux-nfs@vger.kernel.org
Subject: NFS buffered write cleanup
Date: Mon,  1 Jul 2024 07:26:47 +0200	[thread overview]
Message-ID: <20240701052707.1246254-1-hch@lst.de> (raw)

Hi all,

this series cleans up the nfs_page handling in the buffer write path.

The first patch was already sent independently but hasn't been picked up
and this included here again.

The last patch fixes a bug where a request could get incorrectly reused.
It would require the flexfiles layout and odd I/O timings, and without
a flexfiles server I can't actually hit it.  I'd appreciate a careful
review of that one.

The series is against Trond's testing branch.

Diffstat:
 fs/nfs/file.c                  |    6 
 fs/nfs/filelayout/filelayout.c |    1 
 fs/nfs/fscache.c               |    2 
 fs/nfs/internal.h              |    8 -
 fs/nfs/pagelist.c              |  117 ---------------
 fs/nfs/pnfs.h                  |   22 --
 fs/nfs/pnfs_nfs.c              |   47 ------
 fs/nfs/read.c                  |    2 
 fs/nfs/write.c                 |  316 ++++++++++++++++++-----------------------
 include/linux/nfs_page.h       |    7 
 10 files changed, 157 insertions(+), 371 deletions(-)

             reply	other threads:[~2024-07-01  5:27 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01  5:26 Christoph Hellwig [this message]
2024-07-01  5:26 ` [PATCH 1/7] nfs: remove dead code for the old swap over NFS implementation Christoph Hellwig
2024-07-02  7:37   ` Sagi Grimberg
2024-07-01  5:26 ` [PATCH 2/7] nfs: remove nfs_folio_private_request Christoph Hellwig
2024-07-02  7:38   ` Sagi Grimberg
2024-07-01  5:26 ` [PATCH 3/7] nfs: simplify nfs_folio_find_and_lock_request Christoph Hellwig
2024-07-02  7:54   ` Sagi Grimberg
2024-07-03  4:19     ` Christoph Hellwig
2024-07-01  5:26 ` [PATCH 4/7] nfs: fold nfs_folio_find_and_lock_request into nfs_lock_and_join_requests Christoph Hellwig
2024-07-02  7:57   ` Sagi Grimberg
2024-07-03  4:20     ` Christoph Hellwig
2024-07-01  5:26 ` [PATCH 5/7] nfs: fold nfs_page_group_lock_subrequests " Christoph Hellwig
2024-07-02  7:59   ` Sagi Grimberg
2024-07-01  5:26 ` [PATCH 6/7] nfs: move nfs_wait_on_request to write.c Christoph Hellwig
2024-07-02  7:59   ` Sagi Grimberg
2024-07-01  5:26 ` [PATCH 7/7] nfs: don't reuse partially completed requests in nfs_lock_and_join_requests Christoph Hellwig
2024-07-02  8:07   ` Sagi Grimberg
2024-07-03  4:25     ` Christoph Hellwig
2024-07-05  5:35 ` NFS buffered write cleanup Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240701052707.1246254-1-hch@lst.de \
    --to=hch@lst.de \
    --cc=anna@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox