From: Jan Kara <jack@suse.cz>
To: Anna Schumaker <anna@kernel.org>
Cc: Trond Myklebust <trondmy@kernel.org>,
linux-nfs@vger.kernel.org, Sagi Grimberg <sagi@grimberg.me>,
Jeff Layton <jlayton@kernel.org>, Jan Kara <jack@suse.cz>
Subject: [PATCH v2 1/3] nfs: Drop pointless check from nfs_commit_release_pages()
Date: Mon, 1 Jul 2024 12:50:46 +0200 [thread overview]
Message-ID: <20240701105056.25535-1-jack@suse.cz> (raw)
In-Reply-To: <20240617073525.10666-1-jack@suse.cz>
nfss->writeback is updated only when we are ending page writeback and at
that moment we also clear nfss->write_congested. So there's no point in
rechecking congestion state in nfs_commit_release_pages(). Drop the
pointless check.
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/nfs/write.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/fs/nfs/write.c b/fs/nfs/write.c
index 5fc12a721ec3..c6255d7edd3c 100644
--- a/fs/nfs/write.c
+++ b/fs/nfs/write.c
@@ -1837,7 +1837,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
struct nfs_page *req;
int status = data->task.tk_status;
struct nfs_commit_info cinfo;
- struct nfs_server *nfss;
struct folio *folio;
while (!list_empty(&data->pages)) {
@@ -1880,9 +1879,6 @@ static void nfs_commit_release_pages(struct nfs_commit_data *data)
/* Latency breaker */
cond_resched();
}
- nfss = NFS_SERVER(data->inode);
- if (atomic_long_read(&nfss->writeback) < NFS_CONGESTION_OFF_THRESH)
- nfss->write_congested = 0;
nfs_init_cinfo(&cinfo, data->inode, data->dreq);
nfs_commit_end(cinfo.mds);
--
2.35.3
next prev parent reply other threads:[~2024-07-01 10:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 10:50 [PATCH RESEND v2 0/3] nfs: Improve throughput for random buffered writes Jan Kara
2024-07-01 10:50 ` Jan Kara [this message]
2024-07-01 10:50 ` [PATCH v2 2/3] nfs: Properly initialize server->writeback Jan Kara
2024-07-01 11:23 ` Jeff Layton
2024-07-01 10:50 ` [PATCH v2 3/3] nfs: Block on write congestion Jan Kara
2024-07-17 15:58 ` [PATCH RESEND v2 0/3] nfs: Improve throughput for random buffered writes Jan Kara
2024-07-17 17:44 ` Anna Schumaker
2024-07-18 9:47 ` Jan Kara
2024-07-18 19:26 ` Anna Schumaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240701105056.25535-1-jack@suse.cz \
--to=jack@suse.cz \
--cc=anna@kernel.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=sagi@grimberg.me \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox