From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: chuck.lever@oracle.com, jlayton@kernel.org
Cc: neilb@suse.de, okorniev@redhat.com, Dai.Ngo@oracle.com,
tom@talpey.com, linux-nfs@vger.kernel.org
Subject: [PATCH] nfsd: call cache_put if xdr_reserve_space returns NULL
Date: Wed, 21 Aug 2024 22:03:18 +0800 [thread overview]
Message-ID: <20240821140318.7757-1-guoqing.jiang@linux.dev> (raw)
If no enough buffer space available, but idmap_lookup have triggered
lookup_fn which calls cache_get and returns successfully. Then we
missed to call cache_put here which pairs with cache_get.
Signed-off-by: Guoqing Jiang <guoqing.jiang@linux.dev>
---
fs/nfsd/nfs4idmap.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/nfsd/nfs4idmap.c b/fs/nfsd/nfs4idmap.c
index 7a806ac13e31..7abddf7d8f6d 100644
--- a/fs/nfsd/nfs4idmap.c
+++ b/fs/nfsd/nfs4idmap.c
@@ -594,8 +594,10 @@ static __be32 idmap_id_to_name(struct xdr_stream *xdr,
ret = strlen(item->name);
WARN_ON_ONCE(ret > IDMAP_NAMESZ);
p = xdr_reserve_space(xdr, ret + 4);
- if (!p)
+ if (!p) {
+ cache_put(&item->h, nn->idtoname_cache);
return nfserr_resource;
+ }
p = xdr_encode_opaque(p, item->name, ret);
cache_put(&item->h, nn->idtoname_cache);
return 0;
--
2.35.3
next reply other threads:[~2024-08-21 14:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-21 14:03 Guoqing Jiang [this message]
2024-08-26 16:55 ` [PATCH] nfsd: call cache_put if xdr_reserve_space returns NULL Chuck Lever
2024-08-28 10:42 ` Guoqing Jiang
2024-08-29 11:29 ` Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240821140318.7757-1-guoqing.jiang@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox