Linux NFS development
 help / color / mirror / Atom feed
From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: jlayton@kernel.org, neilb@suse.de, okorniev@redhat.com,
	Dai.Ngo@oracle.com, tom@talpey.com, linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: call cache_put if xdr_reserve_space returns NULL
Date: Wed, 28 Aug 2024 18:42:07 +0800	[thread overview]
Message-ID: <f69ab98d-3958-98ca-0c37-affe3571b278@linux.dev> (raw)
In-Reply-To: <ZsyzZ47CKquEy9xV@tissot.1015granger.net>



On 8/27/24 00:55, Chuck Lever wrote:
> On Wed, 21 Aug 2024 22:03:18 +0800, Guoqing Jiang wrote:
>> If no enough buffer space available, but idmap_lookup have triggered
>> lookup_fn which calls cache_get and returns successfully. Then we
>> missed to call cache_put here which pairs with cache_get.
>>
>>
> I've adjusted some aspects of the patch and added a Fixes: tag.

Thanks for the modification!

Guoqing

> Applied to nfsd-next for v6.12, thanks!
>
> [1/1] nfsd: call cache_put if xdr_reserve_space returns NULL
>        commit: ada7d1ab3aa1266b24d08aa4b3df93360a203924


  reply	other threads:[~2024-08-28 10:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-21 14:03 [PATCH] nfsd: call cache_put if xdr_reserve_space returns NULL Guoqing Jiang
2024-08-26 16:55 ` Chuck Lever
2024-08-28 10:42   ` Guoqing Jiang [this message]
2024-08-29 11:29 ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f69ab98d-3958-98ca-0c37-affe3571b278@linux.dev \
    --to=guoqing.jiang@linux.dev \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox