public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] lockd: Fix comment about NLMv3 backwards compatibility
@ 2024-09-12 22:53 Pali Rohár
  2024-09-12 23:10 ` NeilBrown
  2024-10-18 13:38 ` cel
  0 siblings, 2 replies; 9+ messages in thread
From: Pali Rohár @ 2024-09-12 22:53 UTC (permalink / raw)
  To: Chuck Lever, Jeff Layton, Neil Brown, Olga Kornievskaia, Dai Ngo,
	Tom Talpey
  Cc: linux-nfs, linux-kernel

NLMv2 is completely different protocol than NLMv1 and NLMv3, and in
original Sun implementation is used for RPC loopback callbacks from statd
to lockd services. Linux does not use nor does not implement NLMv2.

Hence, NLMv3 is not backward compatible with NLMv2. But NLMv3 is backward
compatible with NLMv1. Fix comment.

Signed-off-by: Pali Rohár <pali@kernel.org>
---
 fs/lockd/clntxdr.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/fs/lockd/clntxdr.c b/fs/lockd/clntxdr.c
index a3e97278b997..81ffa521f945 100644
--- a/fs/lockd/clntxdr.c
+++ b/fs/lockd/clntxdr.c
@@ -3,7 +3,9 @@
  * linux/fs/lockd/clntxdr.c
  *
  * XDR functions to encode/decode NLM version 3 RPC arguments and results.
- * NLM version 3 is backwards compatible with NLM versions 1 and 2.
+ * NLM version 3 is backwards compatible with NLM version 1.
+ * NLM version 2 is different protocol used only for RPC loopback callbacks
+ * from statd to lockd and is not implemented on Linux.
  *
  * NLM client-side only.
  *
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2024-10-18 13:39 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-12 22:53 [PATCH] lockd: Fix comment about NLMv3 backwards compatibility Pali Rohár
2024-09-12 23:10 ` NeilBrown
2024-09-12 23:22   ` Pali Rohár
2024-09-12 23:28     ` Pali Rohár
2024-09-12 23:34       ` Chuck Lever
2024-10-05 16:51         ` Pali Rohár
2024-10-05 17:52           ` Chuck Lever III
2024-10-05 17:56             ` Pali Rohár
2024-10-18 13:38 ` cel

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox