[PATCH] Adjust COMP5 for RFC8276 addition of XATTR ops

[PATCH] Adjust COMP5 for RFC8276 addition of XATTR ops

[Yong Sun]

The COMP5 test needs to be updated for RFC-8276.
This RFC added some new legal opcodes for NFSv4.2 - number 72,73,74,75.
So the '72' should be changed to '76'.
---
 nfs4.1/server41tests/st_compound.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/nfs4.1/server41tests/st_compound.py b/nfs4.1/server41tests/st_compound.py
index fdf73b6..d6bc486 100644
--- a/nfs4.1/server41tests/st_compound.py
+++ b/nfs4.1/server41tests/st_compound.py
@@ -111,7 +111,7 @@ def testUndefined(t, env):
             except:
                 # If it fails, try to just pack the opcode with void args
                 self.pack_uint32_t(data.argop)
-    for i in [0, 1, 2, 72, OP_ILLEGAL]:
+    for i in [0, 1, 2, OP_REMOVEXATTR+1, OP_ILLEGAL]:
         a = nfs_argop4(argop = i)
         try:
             res = c.compound([a], packer=CustomPacker)
-- 
2.43.0

Re: [PATCH] Adjust COMP5 for RFC8276 addition of XATTR ops

[Calum Mackay]

[-- Attachment #1.1: Type: text/plain, Size: 1166 bytes --]

On 24/10/2024 10:10 am, Yong Sun wrote:
> The COMP5 test needs to be updated for RFC-8276.
> This RFC added some new legal opcodes for NFSv4.2 - number 72,73,74,75.
> So the '72' should be changed to '76'.

Thanks very much indeed. Applied.

I've taken the liberty of adding:

	Signed-off-by: Yong Sun <yosun@suse.com>

If you submit any more patches, please include that.

thanks again,
calum.


> ---
>   nfs4.1/server41tests/st_compound.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nfs4.1/server41tests/st_compound.py b/nfs4.1/server41tests/st_compound.py
> index fdf73b6..d6bc486 100644
> --- a/nfs4.1/server41tests/st_compound.py
> +++ b/nfs4.1/server41tests/st_compound.py
> @@ -111,7 +111,7 @@ def testUndefined(t, env):
>               except:
>                   # If it fails, try to just pack the opcode with void args
>                   self.pack_uint32_t(data.argop)
> -    for i in [0, 1, 2, 72, OP_ILLEGAL]:
> +    for i in [0, 1, 2, OP_REMOVEXATTR+1, OP_ILLEGAL]:
>           a = nfs_argop4(argop = i)
>           try:
>               res = c.compound([a], packer=CustomPacker)



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]