* [PATCH] sunrpc: remove newlines from tracepoints
@ 2024-10-29 19:21 Jeff Layton
2024-10-29 19:39 ` Chuck Lever
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2024-10-29 19:21 UTC (permalink / raw)
To: Chuck Lever, Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers
Cc: linux-nfs, linux-kernel, linux-trace-kernel, Jeff Layton
Tracepoint strings don't require newlines (and in fact, they are
undesirable).
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
include/trace/events/sunrpc.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
index 5e8495216689549f1c0bb377911eac4a7bb7b1a8..b13dc275ef4a79940a940dd463b7a3eef5ca428b 100644
--- a/include/trace/events/sunrpc.h
+++ b/include/trace/events/sunrpc.h
@@ -719,7 +719,7 @@ TRACE_EVENT(rpc_xdr_overflow,
),
TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
- " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
+ " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u",
__entry->task_id, __entry->client_id,
__get_str(progname), __entry->version, __get_str(procedure),
__entry->requested, __entry->p, __entry->end,
@@ -777,7 +777,7 @@ TRACE_EVENT(rpc_xdr_alignment,
),
TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
- " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
+ " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u",
__entry->task_id, __entry->client_id,
__get_str(progname), __entry->version, __get_str(procedure),
__entry->offset, __entry->copied,
---
base-commit: 9c9cb4242c49bbadd010e8f0a9e7daf4b392ff6b
change-id: 20241029-tpfix-252e1f852ae4
Best regards,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] sunrpc: remove newlines from tracepoints
2024-10-29 19:21 [PATCH] sunrpc: remove newlines from tracepoints Jeff Layton
@ 2024-10-29 19:39 ` Chuck Lever
2024-10-29 19:42 ` Jeff Layton
0 siblings, 1 reply; 3+ messages in thread
From: Chuck Lever @ 2024-10-29 19:39 UTC (permalink / raw)
To: Jeff Layton
Cc: Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers, linux-nfs,
linux-kernel, linux-trace-kernel
On Tue, Oct 29, 2024 at 03:21:43PM -0400, Jeff Layton wrote:
> Tracepoint strings don't require newlines (and in fact, they are
> undesirable).
>
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> include/trace/events/sunrpc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
> index 5e8495216689549f1c0bb377911eac4a7bb7b1a8..b13dc275ef4a79940a940dd463b7a3eef5ca428b 100644
> --- a/include/trace/events/sunrpc.h
> +++ b/include/trace/events/sunrpc.h
> @@ -719,7 +719,7 @@ TRACE_EVENT(rpc_xdr_overflow,
> ),
>
> TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> - " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> + " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> __entry->task_id, __entry->client_id,
> __get_str(progname), __entry->version, __get_str(procedure),
> __entry->requested, __entry->p, __entry->end,
> @@ -777,7 +777,7 @@ TRACE_EVENT(rpc_xdr_alignment,
> ),
>
> TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> - " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> + " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> __entry->task_id, __entry->client_id,
> __get_str(progname), __entry->version, __get_str(procedure),
> __entry->offset, __entry->copied,
>
> ---
> base-commit: 9c9cb4242c49bbadd010e8f0a9e7daf4b392ff6b
> change-id: 20241029-tpfix-252e1f852ae4
>
> Best regards,
> --
> Jeff Layton <jlayton@kernel.org>
>
Looks like a client-side trace point.
Acked-by: Chuck Lever <chuck.lever@oracle.com>
--
Chuck Lever
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] sunrpc: remove newlines from tracepoints
2024-10-29 19:39 ` Chuck Lever
@ 2024-10-29 19:42 ` Jeff Layton
0 siblings, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2024-10-29 19:42 UTC (permalink / raw)
To: Chuck Lever, Trond Myklebust, Anna Schumaker
Cc: Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey,
Steven Rostedt, Masami Hiramatsu, Mathieu Desnoyers, linux-nfs,
linux-kernel, linux-trace-kernel
On Tue, 2024-10-29 at 15:39 -0400, Chuck Lever wrote:
> On Tue, Oct 29, 2024 at 03:21:43PM -0400, Jeff Layton wrote:
> > Tracepoint strings don't require newlines (and in fact, they are
> > undesirable).
> >
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > include/trace/events/sunrpc.h | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/include/trace/events/sunrpc.h b/include/trace/events/sunrpc.h
> > index 5e8495216689549f1c0bb377911eac4a7bb7b1a8..b13dc275ef4a79940a940dd463b7a3eef5ca428b 100644
> > --- a/include/trace/events/sunrpc.h
> > +++ b/include/trace/events/sunrpc.h
> > @@ -719,7 +719,7 @@ TRACE_EVENT(rpc_xdr_overflow,
> > ),
> >
> > TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> > - " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> > + " %sv%d %s requested=%zu p=%p end=%p xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> > __entry->task_id, __entry->client_id,
> > __get_str(progname), __entry->version, __get_str(procedure),
> > __entry->requested, __entry->p, __entry->end,
> > @@ -777,7 +777,7 @@ TRACE_EVENT(rpc_xdr_alignment,
> > ),
> >
> > TP_printk(SUNRPC_TRACE_TASK_SPECIFIER
> > - " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u\n",
> > + " %sv%d %s offset=%zu copied=%u xdr=[%p,%zu]/%u/[%p,%zu]/%u",
> > __entry->task_id, __entry->client_id,
> > __get_str(progname), __entry->version, __get_str(procedure),
> > __entry->offset, __entry->copied,
> >
> > ---
> > base-commit: 9c9cb4242c49bbadd010e8f0a9e7daf4b392ff6b
> > change-id: 20241029-tpfix-252e1f852ae4
> >
> > Best regards,
> > --
> > Jeff Layton <jlayton@kernel.org>
> >
>
> Looks like a client-side trace point.
>
> Acked-by: Chuck Lever <chuck.lever@oracle.com>
>
Anna, Trond, would you mind picking this one up?
Thanks,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-10-29 19:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-10-29 19:21 [PATCH] sunrpc: remove newlines from tracepoints Jeff Layton
2024-10-29 19:39 ` Chuck Lever
2024-10-29 19:42 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox