public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: NeilBrown <neilb@suse.de>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: [PATCH 0/6 RFC v2] nfsd: allocate/free session-based DRC slots on demand
Date: Tue, 19 Nov 2024 11:41:27 +1100	[thread overview]
Message-ID: <20241119004928.3245873-1-neilb@suse.de> (raw)

Here is v2 of my series for on-demand allocation and freeing of session DRC slots.

- Now uses an xarray to store slots, and the limit is raised to 2048
- delays retiring a slot until the client has confirmed that it isn't
  using it as described in RFC:

      The replier SHOULD retain the slots it wants to retire until the
      requester sends a request with a highest_slotid less than or equal
      to the replier's new enforced highest_slotid.

- When a retired slot is used, allow the seqid to be the next in sequence
  as required by the RFC:

         Each time a slot is reused, the request MUST specify a sequence
         ID that is one greater than that of the previous request on the
         slot.

  or "1" as (arguably) allowed by the RFC:

         The first time a slot is used, the requester MUST specify a
         sequence ID of one

- current slot allocation is now reported in /proc/fs/nfsd/clients/*/info

This has been tested with highly aggressive shrinker settings:
	nfsd_slot_shrinker->seeks = 0;
	nfsd_slot_shrinker->batch = 2;

and with periodic "echo 3 > drop_caches".  The slot count drops as
expected and then increases again.

NeilBrown



             reply	other threads:[~2024-11-19  0:49 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-19  0:41 NeilBrown [this message]
2024-11-19  0:41 ` [PATCH 1/6] nfsd: use an xarray to store v4.1 session slots NeilBrown
2024-11-19  0:41 ` [PATCH 2/6] nfsd: remove artificial limits on the session-based DRC NeilBrown
2024-11-19  0:41 ` [PATCH 3/6] nfsd: add session slot count to /proc/fs/nfsd/clients/*/info NeilBrown
2024-11-19 19:14   ` Chuck Lever
2024-11-19 22:22     ` NeilBrown
2024-11-20  0:21       ` Chuck Lever
2024-11-19 19:21   ` Chuck Lever
2024-11-19 22:24     ` NeilBrown
2024-11-20  0:25       ` Chuck Lever
2024-11-21 21:03         ` NeilBrown
2024-11-21 21:24           ` Chuck Lever III
2024-11-19  0:41 ` [PATCH 4/6] nfsd: allocate new session-based DRC slots on demand NeilBrown
2024-11-19 19:20   ` Chuck Lever
2024-11-19 22:27     ` NeilBrown
2024-11-20  0:32       ` Chuck Lever
2024-11-21 21:20         ` NeilBrown
2024-11-19 19:34   ` Jeff Layton
2024-11-19  0:41 ` [PATCH 5/6] nfsd: add support for freeing unused session-DRC slots NeilBrown
2024-11-19 19:25   ` Chuck Lever
2024-11-19 22:35     ` NeilBrown
2024-11-20  1:27       ` Chuck Lever
2024-11-21 21:47         ` NeilBrown
2024-11-21 22:29           ` Chuck Lever III
2024-12-02 16:11             ` Chuck Lever III
2024-12-03  4:28               ` NeilBrown
2024-12-03 14:40                 ` Chuck Lever III
2024-11-19 19:48   ` Jeff Layton
2024-11-19  0:41 ` [PATCH 6/6] nfsd: add shrinker to reduce number of slots allocated per session NeilBrown
2024-11-19 19:28   ` Chuck Lever
2024-11-19 22:41     ` NeilBrown
2024-11-19 21:17   ` Jeff Layton
2024-11-19 22:47     ` NeilBrown
2024-11-19 21:31 ` [PATCH 0/6 RFC v2] nfsd: allocate/free session-based DRC slots on demand Jeff Layton
2024-11-19 22:52   ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241119004928.3245873-1-neilb@suse.de \
    --to=neilb@suse.de \
    --cc=Dai.Ngo@oracle.com \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox