* [PATCH] NFSD: Clean up unused variable
@ 2024-12-06 21:36 cel
2024-12-10 11:26 ` Benjamin Coddington
2024-12-10 12:45 ` Jeff Layton
0 siblings, 2 replies; 3+ messages in thread
From: cel @ 2024-12-06 21:36 UTC (permalink / raw)
To: Neil Brown, Jeff Layton, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, Chuck Lever
From: Chuck Lever <chuck.lever@oracle.com>
@sb should have been removed by commit 7e64c5bc497c ("NLM/NFSD: Fix
lock notifications for async-capable filesystems").
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfs4state.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 741b9449f727..1272a1fafeb8 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -7966,7 +7966,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
struct nfsd4_blocked_lock *nbl = NULL;
struct file_lock *file_lock = NULL;
struct file_lock *conflock = NULL;
- struct super_block *sb;
__be32 status = 0;
int lkflg;
int err;
@@ -7986,7 +7985,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
status = fh_verify(rqstp, &cstate->current_fh, S_IFREG, 0);
if (status != nfs_ok)
return status;
- sb = cstate->current_fh.fh_dentry->d_sb;
if (lock->lk_is_new) {
if (nfsd4_has_session(cstate))
--
2.47.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] NFSD: Clean up unused variable
2024-12-06 21:36 [PATCH] NFSD: Clean up unused variable cel
@ 2024-12-10 11:26 ` Benjamin Coddington
2024-12-10 12:45 ` Jeff Layton
1 sibling, 0 replies; 3+ messages in thread
From: Benjamin Coddington @ 2024-12-10 11:26 UTC (permalink / raw)
To: cel
Cc: Neil Brown, Jeff Layton, Olga Kornievskaia, Dai Ngo, Tom Talpey,
linux-nfs, Chuck Lever
On 6 Dec 2024, at 16:36, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> @sb should have been removed by commit 7e64c5bc497c ("NLM/NFSD: Fix
> lock notifications for async-capable filesystems").
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
ah, yes thanks.
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] NFSD: Clean up unused variable
2024-12-06 21:36 [PATCH] NFSD: Clean up unused variable cel
2024-12-10 11:26 ` Benjamin Coddington
@ 2024-12-10 12:45 ` Jeff Layton
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2024-12-10 12:45 UTC (permalink / raw)
To: cel, Neil Brown, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, Chuck Lever
On Fri, 2024-12-06 at 16:36 -0500, cel@kernel.org wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> @sb should have been removed by commit 7e64c5bc497c ("NLM/NFSD: Fix
> lock notifications for async-capable filesystems").
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfs4state.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 741b9449f727..1272a1fafeb8 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -7966,7 +7966,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> struct nfsd4_blocked_lock *nbl = NULL;
> struct file_lock *file_lock = NULL;
> struct file_lock *conflock = NULL;
> - struct super_block *sb;
> __be32 status = 0;
> int lkflg;
> int err;
> @@ -7986,7 +7985,6 @@ nfsd4_lock(struct svc_rqst *rqstp, struct nfsd4_compound_state *cstate,
> status = fh_verify(rqstp, &cstate->current_fh, S_IFREG, 0);
> if (status != nfs_ok)
> return status;
> - sb = cstate->current_fh.fh_dentry->d_sb;
>
> if (lock->lk_is_new) {
> if (nfsd4_has_session(cstate))
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-12-10 12:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-06 21:36 [PATCH] NFSD: Clean up unused variable cel
2024-12-10 11:26 ` Benjamin Coddington
2024-12-10 12:45 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox