From: Scott Mayhew <smayhew@redhat.com>
To: steved@redhat.com
Cc: jlayton@kernel.org, linux-nfs@vger.kernel.org
Subject: [nfs-utils PATCH] nfsdctl: fix lockd config during autostart
Date: Thu, 1 May 2025 14:19:28 -0400 [thread overview]
Message-ID: <20250501181928.125198-1-smayhew@redhat.com> (raw)
Be sure to actually send the lockd config values over the netlink
interface.
While we're at it, get rid of the unused "ret" variable.
Fixes: f61c2ff8 ("nfsdctl: add necessary bits to configure lockd")
Signed-off-by: Scott Mayhew <smayhew@redhat.com>
---
utils/nfsdctl/nfsdctl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/utils/nfsdctl/nfsdctl.c b/utils/nfsdctl/nfsdctl.c
index 733756a9..ae435932 100644
--- a/utils/nfsdctl/nfsdctl.c
+++ b/utils/nfsdctl/nfsdctl.c
@@ -1417,7 +1417,6 @@ static int lockd_configure(struct nl_sock *sock, int grace)
{
char *tcp_svc, *udp_svc;
int tcpport = 0, udpport = 0;
- int ret;
tcp_svc = conf_get_str("lockd", "port");
if (tcp_svc) {
@@ -1432,6 +1431,8 @@ static int lockd_configure(struct nl_sock *sock, int grace)
if (udpport < 0)
return 1;
}
+
+ return lockd_config_doit(sock, LOCKD_CMD_SERVER_SET, grace, tcpport, udpport);
}
static int
--
2.48.1
next reply other threads:[~2025-05-01 18:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-01 18:19 Scott Mayhew [this message]
2025-05-02 13:24 ` [nfs-utils PATCH] nfsdctl: fix lockd config during autostart Jeff Layton
2025-05-07 14:08 ` Steve Dickson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250501181928.125198-1-smayhew@redhat.com \
--to=smayhew@redhat.com \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox