Re: [nfs-utils PATCH] nfsdctl: fix lockd config during autostart

[Steve Dickson <steved@redhat.com>]

On 5/1/25 2:19 PM, Scott Mayhew wrote:
> Be sure to actually send the lockd config values over the netlink
> interface.
> 
> While we're at it, get rid of the unused "ret" variable.
> 
> Fixes: f61c2ff8 ("nfsdctl: add necessary bits to configure lockd")
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed... (tag: nfs-utils-2-8-4-rc1)

steved.
> ---
>   utils/nfsdctl/nfsdctl.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/utils/nfsdctl/nfsdctl.c b/utils/nfsdctl/nfsdctl.c
> index 733756a9..ae435932 100644
> --- a/utils/nfsdctl/nfsdctl.c
> +++ b/utils/nfsdctl/nfsdctl.c
> @@ -1417,7 +1417,6 @@ static int lockd_configure(struct nl_sock *sock, int grace)
>   {
>   	char *tcp_svc, *udp_svc;
>   	int tcpport = 0, udpport = 0;
> -	int ret;
>   
>   	tcp_svc = conf_get_str("lockd", "port");
>   	if (tcp_svc) {
> @@ -1432,6 +1431,8 @@ static int lockd_configure(struct nl_sock *sock, int grace)
>   		if (udpport < 0)
>   			return 1;
>   	}
> +
> +	return lockd_config_doit(sock, LOCKD_CMD_SERVER_SET, grace, tcpport, udpport);
>   }
>   
>   static int