From: "hch@lst.de" <hch@lst.de>
To: Trond Myklebust <trondmy@hammerspace.com>
Cc: "hch@lst.de" <hch@lst.de>, "anna@kernel.org" <anna@kernel.org>,
"linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 3/5] nfs: move the call to nfs_pageio_cond_complete in nfs_do_writepage
Date: Wed, 7 May 2025 06:35:56 +0200 [thread overview]
Message-ID: <20250507043556.GA28402@lst.de> (raw)
In-Reply-To: <dcff42774c13403029e187a78196504acebbe142.camel@hammerspace.com>
On Tue, May 06, 2025 at 03:46:13PM +0000, Trond Myklebust wrote:
> Maybe collapse this patch and 1/5? 🙂
Oops, I didn't realize it was me who messed up the function call
placement. Yes, this should be fixed at the source.
next prev parent reply other threads:[~2025-05-07 4:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 14:07 writeback cleanups Christoph Hellwig
2025-05-06 14:07 ` [PATCH 1/5] nfs: fold nfs_page_async_flush into nfs_do_writepage Christoph Hellwig
2025-05-06 14:07 ` [PATCH 2/5] nfs: don't return AOP_WRITEPAGE_ACTIVATE from nfs_do_writepage Christoph Hellwig
2025-05-06 14:07 ` [PATCH 3/5] nfs: move the call to nfs_pageio_cond_complete in nfs_do_writepage Christoph Hellwig
2025-05-06 15:46 ` Trond Myklebust
2025-05-07 4:35 ` hch [this message]
2025-05-06 14:07 ` [PATCH 4/5] nfs: refactor nfs_do_writepage Christoph Hellwig
2025-05-06 14:07 ` [PATCH 5/5] nfs: use writeback_iter directly Christoph Hellwig
2025-05-06 15:51 ` writeback cleanups Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250507043556.GA28402@lst.de \
--to=hch@lst.de \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox