public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Trond Myklebust <trondmy@hammerspace.com>
To: "hch@lst.de" <hch@lst.de>, "anna@kernel.org" <anna@kernel.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: writeback cleanups
Date: Tue, 6 May 2025 15:51:12 +0000	[thread overview]
Message-ID: <613400577d55696753fc99ee7a8376996690fc69.camel@hammerspace.com> (raw)
In-Reply-To: <20250506140815.3761765-1-hch@lst.de>

On Tue, 2025-05-06 at 16:07 +0200, Christoph Hellwig wrote:
> Hi all,
> 
> this series has a bunch of cosmetic cleanups for the NFS folio
> writeback
> code.
> 
> Diffstat:
>  write.c |   54 +++++++++++++++++++----------------------------------
> -
>  1 file changed, 19 insertions(+), 35 deletions(-)

Looks good, but as I said, Patch 1 & 3 want to be squashed together.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com

      parent reply	other threads:[~2025-05-06 15:51 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-05-06 14:07 writeback cleanups Christoph Hellwig
2025-05-06 14:07 ` [PATCH 1/5] nfs: fold nfs_page_async_flush into nfs_do_writepage Christoph Hellwig
2025-05-06 14:07 ` [PATCH 2/5] nfs: don't return AOP_WRITEPAGE_ACTIVATE from nfs_do_writepage Christoph Hellwig
2025-05-06 14:07 ` [PATCH 3/5] nfs: move the call to nfs_pageio_cond_complete in nfs_do_writepage Christoph Hellwig
2025-05-06 15:46   ` Trond Myklebust
2025-05-07  4:35     ` hch
2025-05-06 14:07 ` [PATCH 4/5] nfs: refactor nfs_do_writepage Christoph Hellwig
2025-05-06 14:07 ` [PATCH 5/5] nfs: use writeback_iter directly Christoph Hellwig
2025-05-06 15:51 ` Trond Myklebust [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=613400577d55696753fc99ee7a8376996690fc69.camel@hammerspace.com \
    --to=trondmy@hammerspace.com \
    --cc=anna@kernel.org \
    --cc=hch@lst.de \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox