From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trondmy@kernel.org>
Cc: Anna Schumaker <anna@kernel.org>, linux-nfs@vger.kernel.org
Subject: use a hash for looking up delegation v2
Date: Wed, 16 Jul 2025 15:26:30 +0200 [thread overview]
Message-ID: <20250716132657.2167548-1-hch@lst.de> (raw)
Hi all,
currently recalling delegations has to walk the server->delegations
list, and then take the lock for each delegation. This can take a lot of
time and has adverse effects to the rest of the system due to the number
atomic operations, cache lines touched and a long RCU critical section.
This series first converts the delegation watermark to be per-server, as
all the state guarded by it is per-server and the commit message adding
it talks about server side overhead as well, and then adds a very simple
hash for finding the delegation for a given file handle in
nfs_delegation_find_inode_server.
With this hash sample microbenchmarks that cause delegation recalls in
reverse list order are sped up ~5 percent, although the time is still
very variable due to other factors.
Changes since v1:
- only allocate the delegation hash for v4 mounts
Diffstat:
fs/nfs/client.c | 15 +++++-
fs/nfs/delegation.c | 110 ++++++++++++++++++++++++++++------------------
fs/nfs/delegation.h | 3 +
fs/nfs/nfs4client.c | 10 +++-
include/linux/nfs_fs_sb.h | 3 +
5 files changed, 96 insertions(+), 45 deletions(-)
next reply other threads:[~2025-07-16 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-16 13:26 Christoph Hellwig [this message]
2025-07-16 13:26 ` [PATCH 1/4] NFS: cleanup nfs_inode_reclaim_delegation Christoph Hellwig
2025-07-16 13:26 ` [PATCH 2/4] NFS: move the delegation_watermark module parameter Christoph Hellwig
2025-07-16 13:26 ` [PATCH 3/4] NFS: track active delegations per-server Christoph Hellwig
2025-07-16 13:26 ` [PATCH 4/4] NFS: use a hash table for delegation lookup Christoph Hellwig
2025-07-17 4:35 ` kernel test robot
2025-07-17 5:13 ` Christoph Hellwig
2025-07-17 16:00 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250716132657.2167548-1-hch@lst.de \
--to=hch@lst.de \
--cc=anna@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox