Linux NFS development
 help / color / mirror / Atom feed
From: Trond Myklebust <trondmy@kernel.org>
To: Christoph Hellwig <hch@lst.de>, Anna Schumaker <anna@kernel.org>,
	Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 4/4] NFS: use a hash table for delegation lookup
Date: Thu, 17 Jul 2025 09:00:39 -0700	[thread overview]
Message-ID: <2ec3e240e811d9881f1513acaa06aff508bb996c.camel@kernel.org> (raw)
In-Reply-To: <20250717051315.GA27362@lst.de>

On Thu, 2025-07-17 at 07:13 +0200, Christoph Hellwig wrote:
> So nfs4 can be built modular, and delegation.o is built into that,
> i.e. we can't call into deletation code from clone_server.
> 
> Back to passing a major number to nfs_alloc_server?

Why not just build a small wrapper in fs/nfs/nfs4proc.c that does the
allocation after calling the regular nfs_clone_server(), and substitute
that into the nfs_v4_clientops.clone_server callback?

> 
> On Thu, Jul 17, 2025 at 12:35:07PM +0800, kernel test robot wrote:
> > Hi Christoph,
> > 
> > kernel test robot noticed the following build errors:
> > 
> > [auto build test ERROR on trondmy-nfs/linux-next]
> > [also build test ERROR on linus/master v6.16-rc6 next-20250716]
> > [If your patch is applied to the wrong git tree, kindly drop us a
> > note.
> > And when submitting patch, we suggest to use '--base' as documented
> > in

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trondmy@kernel.org, trond.myklebust@hammerspace.com

  reply	other threads:[~2025-07-17 16:00 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-16 13:26 use a hash for looking up delegation v2 Christoph Hellwig
2025-07-16 13:26 ` [PATCH 1/4] NFS: cleanup nfs_inode_reclaim_delegation Christoph Hellwig
2025-07-16 13:26 ` [PATCH 2/4] NFS: move the delegation_watermark module parameter Christoph Hellwig
2025-07-16 13:26 ` [PATCH 3/4] NFS: track active delegations per-server Christoph Hellwig
2025-07-16 13:26 ` [PATCH 4/4] NFS: use a hash table for delegation lookup Christoph Hellwig
2025-07-17  4:35   ` kernel test robot
2025-07-17  5:13     ` Christoph Hellwig
2025-07-17 16:00       ` Trond Myklebust [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-07-14 11:16 use a hash for looking up delegation Christoph Hellwig
2025-07-14 11:16 ` [PATCH 4/4] NFS: use a hash table for delegation lookup Christoph Hellwig
2025-07-14 13:14   ` Jeff Layton
2025-07-14 13:18     ` Christoph Hellwig
2025-07-15  8:58     ` Christoph Hellwig
2025-07-15 11:19       ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2ec3e240e811d9881f1513acaa06aff508bb996c.camel@kernel.org \
    --to=trondmy@kernel.org \
    --cc=anna@kernel.org \
    --cc=hch@lst.de \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox