From: Jeff Layton <jlayton@kernel.org>
To: Calum Mackay <calum.mackay@oracle.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH pynfs v2 10/25] server41tests: test no notifications without GFLAG_EXTEND
Date: Thu, 16 Apr 2026 11:14:42 -0700 [thread overview]
Message-ID: <20260416-dir-deleg-v2-10-fad510db5941@kernel.org> (raw)
In-Reply-To: <20260416-dir-deleg-v2-0-fad510db5941@kernel.org>
Request a dir delegation with NOTIFY4_ADD_ENTRY but without
NOTIFY4_GFLAG_EXTEND. Verify the server issues a CB_RECALL
instead of CB_NOTIFY when a file is created.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
nfs4.1/server41tests/st_dir_deleg.py | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/nfs4.1/server41tests/st_dir_deleg.py b/nfs4.1/server41tests/st_dir_deleg.py
index 808323b89ffa..7d1e664a7923 100644
--- a/nfs4.1/server41tests/st_dir_deleg.py
+++ b/nfs4.1/server41tests/st_dir_deleg.py
@@ -267,3 +267,33 @@ def testDirDelegLinkRecall(t, env):
ops = [ op.putfh(fh), op.delegreturn(deleg) ]
res = sess1.compound(ops)
check(res)
+
+def testDirDelegNoGflag(t, env):
+ """Verify recall instead of notification without NOTIFY4_GFLAG_EXTEND
+
+ FLAGS: dirdeleg all
+ CODE: DIRDELEG7
+ """
+ c = env.c1
+ cb = threading.Event()
+ sess1, fh, deleg = _getDirDeleg(t, env, [NOTIFY4_ADD_ENTRY], cb)
+
+ sess2 = c.new_client_session(b"%s_2" % env.testname(t))
+ claim = open_claim4(CLAIM_NULL, env.testname(t))
+ owner = open_owner4(0, b"owner")
+ how = openflag4(OPEN4_CREATE, createhow4(GUARDED4, {FATTR4_SIZE:0}))
+ open_op = [ op.putfh(fh), op.open(0,
+ OPEN4_SHARE_ACCESS_WRITE | OPEN4_SHARE_ACCESS_WANT_NO_DELEG,
+ OPEN4_SHARE_DENY_NONE, owner, how, claim) ]
+ slot = sess2.compound_async(open_op)
+ completed = cb.wait(2)
+ env.sleep(.1)
+
+ ops = [ op.putfh(fh), op.delegreturn(deleg) ]
+ res = sess1.compound(ops)
+ check(res)
+
+ if cb.got_notify:
+ fail("Got CB_NOTIFY without GFLAG_EXTEND")
+ if not cb.got_recall:
+ fail("Expected CB_RECALL without GFLAG_EXTEND, but didn't get one")
--
2.53.0
next prev parent reply other threads:[~2026-04-16 18:15 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-16 18:14 [PATCH pynfs v2 00/25] nfs4.1: add some directory delegation testcases Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 01/25] nfs4.1: add proposed NOTIFY4_GFLAG_EXTEND flag Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 02/25] nfs4.1: add a getfh() to the end of create_obj() compound Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 03/25] server41tests: add a basic GET_DIR_DELEGATION test Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 04/25] server41tests: add a test for duplicate GET_DIR_DELEGATION requests Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 05/25] server41tests: pass_warn() when server doesn't support dir delegations Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 06/25] server41tests: test remove triggers dir delegation recall Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 07/25] server41tests: test rename " Jeff Layton
2026-04-17 0:40 ` Scott Mayhew
2026-04-17 15:42 ` Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 08/25] server41tests: test mkdir " Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 09/25] server41tests: test link " Jeff Layton
2026-04-16 18:14 ` Jeff Layton [this message]
2026-04-16 18:14 ` [PATCH pynfs v2 11/25] server41tests: test unrequested notification type triggers recall Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 12/25] server41tests: add a test for removal from dir with dir delegation Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 13/25] server41tests: add a test for directory add notifications Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 14/25] server41tests: add test for RENAME event notifications Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 15/25] server41tests: verify child attributes in ADD notification Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 16/25] server41tests: test CHANGE_DIR_ATTRS notification Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 17/25] server41tests: test mkdir triggers ADD notification Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 18/25] server41tests: test DELEGRETURN stops notifications Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 19/25] server41tests: verify filehandle in ADD notification Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 20/25] server41tests: test cross-directory rename REMOVE notification Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 21/25] server41tests: test cross-directory rename ADD notification on target Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 22/25] server41tests: test link triggers ADD notification Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 23/25] server41tests: test same-client changes don't trigger notifications Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 24/25] server41tests: test cross-directory rename-over nad_old_entry Jeff Layton
2026-04-16 18:14 ` [PATCH pynfs v2 25/25] server41tests: test within-directory " Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260416-dir-deleg-v2-10-fad510db5941@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=calum.mackay@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox