Re: [PATCH pynfs v2 07/25] server41tests: test rename triggers dir delegation recall

[Scott Mayhew <smayhew@redhat.com>]

On Thu, 16 Apr 2026, Jeff Layton wrote:

> Get a dir delegation with no notification mask, create a file, then
> rename it from a second client. Verify that the server issues a
> CB_RECALL.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  nfs4.1/server41tests/st_dir_deleg.py | 33 +++++++++++++++++++++++++++++++++
>  1 file changed, 33 insertions(+)
> 
> diff --git a/nfs4.1/server41tests/st_dir_deleg.py b/nfs4.1/server41tests/st_dir_deleg.py
> index f5265e8cf0ab..d8d09cd4bf7e 100644
> --- a/nfs4.1/server41tests/st_dir_deleg.py
> +++ b/nfs4.1/server41tests/st_dir_deleg.py
> @@ -175,3 +175,36 @@ def testDirDelegRemoveRecall(t, env):
>      ops = [ op.putfh(fh), op.delegreturn(deleg) ]
>      res = sess1.compound(ops)
>      check(res)
> +
> +def testDirDelegRenameRecall(t, env):
> +    """Verify rename triggers dir delegation recall
> +
> +    FLAGS: dirdeleg all
> +    CODE: DIRDELEG4
> +    """
> +    c = env.c1
> +    recall = threading.Event()
> +    sess1, fh, deleg = _getDirDeleg(t, env, [], recall)
> +
> +    # Create a file from sess1
> +    claim = open_claim4(CLAIM_NULL, env.testname(t))
> +    owner = open_owner4(0, b"owner")
> +    how = openflag4(OPEN4_CREATE, createhow4(GUARDED4, {FATTR4_SIZE:0}))
> +    open_op = [ op.putfh(fh), op.open(0,
> +                                      OPEN4_SHARE_ACCESS_WRITE | OPEN4_SHARE_ACCESS_WANT_NO_DELEG,
> +                                      OPEN4_SHARE_DENY_NONE, owner, how, claim) ]
> +    res = sess1.compound(open_op)
> +    check(res)

You probably want to close this file at the end of the test so you're
not leaving state behind on the server.

-Scott
> +
> +    # Rename the file from sess2 -- should trigger recall
> +    sess2 = c.new_client_session(b"%s_2" % env.testname(t))
> +    rename_op = [ op.putfh(fh), op.savefh(),
> +                  op.putfh(fh),
> +                  op.rename(env.testname(t), b"%s_2" % env.testname(t)) ]
> +    slot = sess2.compound_async(rename_op)
> +    completed = recall.wait(2)
> +    env.sleep(.1)
> +
> +    ops = [ op.putfh(fh), op.delegreturn(deleg) ]
> +    res = sess1.compound(ops)
> +    check(res)
> 
> -- 
> 2.53.0
> 
>