From: Jeff Layton <jlayton@kernel.org>
To: Calum Mackay <calum.mackay@oracle.com>
Cc: Chuck Lever <chuck.lever@oracle.com>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>,
Trond Myklebust <trondmy@kernel.org>,
Anna Schumaker <anna@kernel.org>,
Scott Mayhew <smayhew@redhat.com>,
linux-nfs@vger.kernel.org, Jeff Layton <jlayton@kernel.org>
Subject: [PATCH pynfs v3 26/26] nfs4.1: move a lot of log/log_cb.info messages to log/log_cb.debug
Date: Fri, 19 Jun 2026 15:22:45 -0400 [thread overview]
Message-ID: <20260619-dir-deleg-v3-26-1077ce8aab1b@kernel.org> (raw)
In-Reply-To: <20260619-dir-deleg-v3-0-1077ce8aab1b@kernel.org>
Most of these are note terribly useful in the normal case. Change them
from info level to debug.
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
nfs4.1/nfs4client.py | 38 +++++++++++++++++------------------
nfs4.1/server41tests/environment.py | 4 ++--
nfs4.1/server41tests/st_delegation.py | 3 ---
3 files changed, 21 insertions(+), 24 deletions(-)
diff --git a/nfs4.1/nfs4client.py b/nfs4.1/nfs4client.py
index dbe7af761f16..79df26ea1cda 100644
--- a/nfs4.1/nfs4client.py
+++ b/nfs4.1/nfs4client.py
@@ -83,7 +83,7 @@ class NFS4Client(rpc.Client, rpc.Server):
p = packer(check_enum=checks, check_array=checks)
c4 = COMPOUND4args(tag, version, ops)
if SHOW_TRAFFIC:
- log_cb.info("compound args = %r" % (c4,))
+ log_cb.debug("compound args = %r" % (c4,))
p.pack_COMPOUND4args(c4)
return self.send_call(pipe, 1, p.get_buffer(), credinfo)
@@ -93,7 +93,7 @@ class NFS4Client(rpc.Client, rpc.Server):
pipe = kwargs.get("pipe", None)
res = self.listen(xid, pipe=pipe)
if SHOW_TRAFFIC:
- log_cb.info("compound result = %r" % (res,))
+ log_cb.debug("compound result = %r" % (res,))
if self.summary:
self.summary.show_op('call v4.1 %s:%s' % self.server_address,
[ nfs_opnum4[a.argop].lower()[3:] for a in args[0] ],
@@ -112,8 +112,8 @@ class NFS4Client(rpc.Client, rpc.Server):
def handle_0(self, data, cred):
"""NULL procedure"""
allow_null_data = True
- log_cb.info("*" * 20)
- log_cb.info("Handling CB_NULL")
+ log_cb.debug("*" * 20)
+ log_cb.debug("Handling CB_NULL")
if data and not allow_null_data:
return rpc.GARBAGE_ARGS, None
else:
@@ -121,16 +121,16 @@ class NFS4Client(rpc.Client, rpc.Server):
def handle_1(self, data, cred):
# STUB
- log_cb.info("*" * 20)
- log_cb.info("Handling CB_COMPOUND")
+ log_cb.debug("*" * 20)
+ log_cb.debug("Handling CB_COMPOUND")
p = nfs4lib.FancyNFS4Packer()
res = CB_COMPOUND4res(NFS4ERR_BACK_CHAN_BUSY, "STUB CB_REPLY", [])
p.pack_CB_COMPOUND4res(res)
return rpc.SUCCESS, p.get_buffer()
def handle_1(self, data, cred):
- log_cb.info("*" * 20)
- log_cb.info("Handling COMPOUND")
+ log_cb.debug("*" * 20)
+ log_cb.debug("Handling COMPOUND")
# data is an XDR packed string. Unpack it.
unpacker = nfs4lib.FancyNFS4Unpacker(data)
try:
@@ -146,7 +146,7 @@ class NFS4Client(rpc.Client, rpc.Server):
args.req_size = len(data)
# Handle the request
env = self.op_cb_compound(args, cred)
- log_cb.info(repr(env.results.reply.results))
+ log_cb.debug(repr(env.results.reply.results))
# Pack the results back into an XDR string
p = nfs4lib.FancyNFS4Packer()
p.pack_CB_COMPOUND4res(CB_COMPOUND4res(env.results.reply.status,
@@ -162,9 +162,9 @@ class NFS4Client(rpc.Client, rpc.Server):
env.cache.data = p.get_buffer()
env.cache.valid.set()
except NFS4Replay as e:
- log_cb.info("Replay...waiting for valid data")
+ log_cb.debug("Replay...waiting for valid data")
e.cache.valid.wait()
- log_cb.info("Replay...sending data")
+ log_cb.debug("Replay...sending data")
data = e.cache.data
return rpc.SUCCESS, data, getattr(env, "notify", None)
@@ -190,7 +190,7 @@ class NFS4Client(rpc.Client, rpc.Server):
status = NFS4_OK
for arg in args.argarray:
opname = nfs_cb_opnum4.get(arg.argop, 'op_cb_illegal')
- log_cb.info("*** %s (%d) ***" % (opname, arg.argop))
+ log_cb.debug("*** %s (%d) ***" % (opname, arg.argop))
env.index += 1
# Look for function self.op_<name>
funct = getattr(self, opname.lower(), None)
@@ -220,7 +220,7 @@ class NFS4Client(rpc.Client, rpc.Server):
status = result.status
if status != NFS4_OK:
break
- log_cb.info("Replying. Status %s (%d)" % (nfsstat4[status], status))
+ log_cb.debug("Replying. Status %s (%d)" % (nfsstat4[status], status))
return env
def prehook(self, arg, env):
@@ -248,7 +248,7 @@ class NFS4Client(rpc.Client, rpc.Server):
return funct(arg, env, res)
def op_cb_sequence(self, arg, env):
- log_cb.info("In CB_SEQUENCE")
+ log_cb.debug("In CB_SEQUENCE")
if env.index != 0:
return encode_status(NFS4ERR_SEQUENCE_POS)
session = self.sessions.get(arg.csa_sessionid, None)
@@ -272,31 +272,31 @@ class NFS4Client(rpc.Client, rpc.Server):
return encode_status(NFS4_OK, res)
def op_cb_getattr(self, arg, env):
- log_cb.info("In CB_GETATTR")
+ log_cb.debug("In CB_GETATTR")
self.prehook(arg, env)
res = self.posthook(arg, env, res=CB_GETATTR4resok())
return encode_status(NFS4_OK, res)
def op_cb_recall(self, arg, env):
- log_cb.info("In CB_RECALL")
+ log_cb.debug("In CB_RECALL")
self.prehook(arg, env)
res = self.posthook(arg, env, res=NFS4_OK)
return encode_status(res)
def op_cb_notify(self, arg, env):
- log_cb.info("In CB_NOTIFY")
+ log_cb.debug("In CB_NOTIFY")
self.prehook(arg, env)
res = self.posthook(arg, env, res=NFS4_OK)
return encode_status(res)
def op_cb_notify_lock(self, arg, env):
- log_cb.info("In CB_NOTIFY_LOCK")
+ log_cb.debug("In CB_NOTIFY_LOCK")
self.prehook(arg, env)
res = self.posthook(arg, env, res=NFS4_OK)
return encode_status(res)
def op_cb_layoutrecall(self, arg, env):
- log_cb.info("In CB_LAYOUTRECALL")
+ log_cb.debug("In CB_LAYOUTRECALL")
self.prehook(arg, env)
res = self.posthook(arg, env, res=NFS4_OK)
if res is not NFS4_OK:
diff --git a/nfs4.1/server41tests/environment.py b/nfs4.1/server41tests/environment.py
index f5b1fea4a64c..c14b12cbfca5 100644
--- a/nfs4.1/server41tests/environment.py
+++ b/nfs4.1/server41tests/environment.py
@@ -443,7 +443,7 @@ def do_readdir(sess, file, cookie=0, cookieverf=b'', attrs=0,
# Since we may not get whole directory listing in one readdir request,
# loop until we do. For each request result, create a flat list
# with <entry4> objects.
- log.info("Called do_readdir()")
+ log.debug("Called do_readdir()")
entries = []
baseops = use_obj(file)
while True:
@@ -458,7 +458,7 @@ def do_readdir(sess, file, cookie=0, cookieverf=b'', attrs=0,
break
cookie = entries[-1].cookie
cookieverf = res.resarray[-1].cookieverf
- log.info("do_readdir() = %r" % entries)
+ log.debug("do_readdir() = %r" % entries)
return entries
def do_getattrdict(sess, file, attrlist):
diff --git a/nfs4.1/server41tests/st_delegation.py b/nfs4.1/server41tests/st_delegation.py
index 41095b98a7a4..a67a3ba9e73f 100644
--- a/nfs4.1/server41tests/st_delegation.py
+++ b/nfs4.1/server41tests/st_delegation.py
@@ -266,10 +266,8 @@ def testServerSelfConflict3(t, env):
fh, deleg = __create_file_with_deleg(sess1, env.testname(t),
OPEN4_SHARE_ACCESS_READ | OPEN4_SHARE_ACCESS_WANT_READ_DELEG)
- print("__create_file_with_deleg: ", fh, deleg)
delegstateid = deleg.read.stateid
res = open_file(sess1, env.testname(t), access = OPEN4_SHARE_ACCESS_WRITE)
- print("open_file res: ", res)
check(res)
# XXX: cut-n-paste from _testDeleg; make helper instead:
@@ -319,7 +317,6 @@ def _testCbGetattr(t, env, change=0, size=0):
openmask |= 1<<OPEN_ARGS_SHARE_ACCESS_WANT_DELEG_TIMESTAMPS
fh, deleg = __create_file_with_deleg(sess1, env.testname(t), openmask)
- print("__create_file_with_deleg: ", fh, deleg)
attrs1 = do_getattrdict(sess1, fh, [FATTR4_CHANGE, FATTR4_SIZE,
FATTR4_TIME_ACCESS, FATTR4_TIME_MODIFY])
--
2.54.0
next prev parent reply other threads:[~2026-06-19 19:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-19 19:22 [PATCH pynfs v3 00/26] nfs4.1: add some directory delegation testcases Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 01/26] nfs4.1: add proposed NOTIFY4_GFLAG_EXTEND flag Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 02/26] nfs4.1: add a getfh() to the end of create_obj() compound Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 03/26] server41tests: add a basic GET_DIR_DELEGATION test Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 04/26] server41tests: add a test for duplicate GET_DIR_DELEGATION requests Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 05/26] server41tests: pass_warn() when server doesn't support dir delegations Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 06/26] server41tests: test remove triggers dir delegation recall Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 07/26] server41tests: test rename " Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 08/26] server41tests: test mkdir " Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 09/26] server41tests: test link " Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 10/26] server41tests: test no notifications without GFLAG_EXTEND Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 11/26] server41tests: test unrequested notification type triggers recall Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 12/26] server41tests: add a test for removal from dir with dir delegation Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 13/26] server41tests: add a test for directory add notifications Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 14/26] server41tests: add test for RENAME event notifications Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 15/26] server41tests: verify child attributes in ADD notification Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 16/26] server41tests: test CHANGE_DIR_ATTRS notification Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 17/26] server41tests: test mkdir triggers ADD notification Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 18/26] server41tests: test DELEGRETURN stops notifications Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 19/26] server41tests: verify filehandle in ADD notification Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 20/26] server41tests: test cross-directory rename REMOVE notification Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 21/26] server41tests: test cross-directory rename ADD notification on target Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 22/26] server41tests: test link triggers ADD notification Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 23/26] server41tests: test same-client changes don't trigger notifications Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 24/26] server41tests: test cross-directory rename-over nad_old_entry Jeff Layton
2026-06-19 19:22 ` [PATCH pynfs v3 25/26] server41tests: test within-directory " Jeff Layton
2026-06-19 19:22 ` Jeff Layton [this message]
2026-06-23 21:33 ` [PATCH pynfs v3 00/26] nfs4.1: add some directory delegation testcases Calum Mackay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260619-dir-deleg-v3-26-1077ce8aab1b@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=calum.mackay@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=smayhew@redhat.com \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox