Re: [PATCH pynfs v3 00/26] nfs4.1: add some directory delegation testcases

[Calum Mackay <calum.mackay@oracle.com>]

Thanks very much Jeff,

I have a bit of a backlog, again, but will get to these asap.

cheers,
c.


On 19/06/2026 8:22 pm, Jeff Layton wrote:
> Long delay since v2, but the CB_NOTIFY patches only recently got merged
> into Chuck's nfsd-testing branch. They're currently slated to make v7.3.
> This version of the series fixes some potential state leaks that Scott
> pointed out, and adds a patch to make the output a bit less chatty with
> normal settings.
> 
> Original cover letter follows:
> 
> ---------------------8<-------------------
> 
> This patchset adds some new testcases for directory delegations.
> 
> DIRDELEG1-7 should pass on current mainline kernels, with recall-only
> support. The rest require CB_NOTIFY support. If the server doesn't
> offer notifications, then the tests pass_warn (so there should be no
> failures in those cases):
> 
>      https://lore.kernel.org/linux-nfs/20260416-dir-deleg-v2-0-851426a550f6@kernel.org/
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> 
> ---
> Changes in v3:
> - Ensure we clean up state after tests
> - Demote some extra-chatty messages to debug level
> - Link to v2: https://lore.kernel.org/r/20260416-dir-deleg-v2-0-fad510db5941@kernel.org
> 
> Changes in v2:
> - Added more tests for CB_NOTIFY behavior
> - Link to v1: https://lore.kernel.org/r/20260407-dir-deleg-v1-0-54c998eab72b@kernel.org
> 
> ---
> Jeff Layton (26):
>        nfs4.1: add proposed NOTIFY4_GFLAG_EXTEND flag
>        nfs4.1: add a getfh() to the end of create_obj() compound
>        server41tests: add a basic GET_DIR_DELEGATION test
>        server41tests: add a test for duplicate GET_DIR_DELEGATION requests
>        server41tests: pass_warn() when server doesn't support dir delegations
>        server41tests: test remove triggers dir delegation recall
>        server41tests: test rename triggers dir delegation recall
>        server41tests: test mkdir triggers dir delegation recall
>        server41tests: test link triggers dir delegation recall
>        server41tests: test no notifications without GFLAG_EXTEND
>        server41tests: test unrequested notification type triggers recall
>        server41tests: add a test for removal from dir with dir delegation
>        server41tests: add a test for directory add notifications
>        server41tests: add test for RENAME event notifications
>        server41tests: verify child attributes in ADD notification
>        server41tests: test CHANGE_DIR_ATTRS notification
>        server41tests: test mkdir triggers ADD notification
>        server41tests: test DELEGRETURN stops notifications
>        server41tests: verify filehandle in ADD notification
>        server41tests: test cross-directory rename REMOVE notification
>        server41tests: test cross-directory rename ADD notification on target
>        server41tests: test link triggers ADD notification
>        server41tests: test same-client changes don't trigger notifications
>        server41tests: test cross-directory rename-over nad_old_entry
>        server41tests: test within-directory rename-over nad_old_entry
>        nfs4.1: move a lot of log/log_cb.info messages to log/log_cb.debug
> 
>   nfs4.1/nfs4client.py                  |   42 +-
>   nfs4.1/server41tests/__init__.py      |    1 +
>   nfs4.1/server41tests/environment.py   |    6 +-
>   nfs4.1/server41tests/st_delegation.py |    3 -
>   nfs4.1/server41tests/st_dir_deleg.py  | 1117 +++++++++++++++++++++++++++++++++
>   nfs4.1/xdrdef/nfs4.x                  |    3 +-
>   6 files changed, 1147 insertions(+), 25 deletions(-)
> ---
> base-commit: cd4701827a8261fedbfb4c6e39029fb9671321a6
> change-id: 20260331-dir-deleg-a1b3475f8385
> 
> Best regards,