* [PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc
@ 2026-09-09 6:43 Karl Mehltretter
2026-09-09 14:12 ` Chuck Lever
0 siblings, 1 reply; 2+ messages in thread
From: Karl Mehltretter @ 2026-09-09 6:43 UTC (permalink / raw)
To: Chuck Lever
Cc: Karl Mehltretter, Trond Myklebust, Anna Schumaker, Jeff Layton,
NeilBrown, Olga Kornievskaia, Dai Ngo, Tom Talpey, linux-nfs,
linux-kernel
svc_rdma_recv_cid_init() initializes a Receive Queue completion ID,
but its kernel-doc heading names svc_rdma_send_cid_init(). The latter is
a separate helper immediately below it, so kernel-doc cannot match this
comment to the receive helper.
Fix the copied function name.
Fixes: 28ee0ec8948a ("svcrdma: De-duplicate completion ID initialization helpers")
Assisted-by: LLM
Signed-off-by: Karl Mehltretter <kmehltretter@gmail.com>
---
include/linux/sunrpc/svc_rdma.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
index 76aa5ec4ab40..5ccb13bf906f 100644
--- a/include/linux/sunrpc/svc_rdma.h
+++ b/include/linux/sunrpc/svc_rdma.h
@@ -142,7 +142,7 @@ enum {
#define RPCSVC_MAXPAYLOAD_RDMA RPCSVC_MAXPAYLOAD
/**
- * svc_rdma_send_cid_init - Initialize a Receive Queue completion ID
+ * svc_rdma_recv_cid_init - Initialize a Receive Queue completion ID
* @rdma: controlling transport
* @cid: completion ID to initialize
*/
base-commit: 893e11787f78e43b534e252249ac3fff4d1333f8
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc
2026-09-09 6:43 [PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc Karl Mehltretter
@ 2026-09-09 14:12 ` Chuck Lever
0 siblings, 0 replies; 2+ messages in thread
From: Chuck Lever @ 2026-09-09 14:12 UTC (permalink / raw)
To: Karl Mehltretter
Cc: Trond Myklebust, Anna Schumaker, Jeff Layton, NeilBrown,
Olga Kornievskaia, Dai Ngo, Tom Talpey, linux-nfs, linux-kernel
On Wed, 09 Sep 2026 08:43:43 +0200, Karl Mehltretter wrote:
> svc_rdma_recv_cid_init() initializes a Receive Queue completion ID,
> but its kernel-doc heading names svc_rdma_send_cid_init(). The latter is
> a separate helper immediately below it, so kernel-doc cannot match this
> comment to the receive helper.
>
> Fix the copied function name.
>
> [...]
Applied to nfsd-testing, thanks!
[1/1] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc
(no commit info)
--
Chuck Lever
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-09 14:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-09 6:43 [PATCH] svcrdma: Fix svc_rdma_recv_cid_init() kernel-doc Karl Mehltretter
2026-09-09 14:12 ` Chuck Lever
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox