From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, NeilBrown <neil@brown.name>,
Olga Kornievskaia <okorniev@redhat.com>,
Dai Ngo <dai.ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes
Date: Wed, 01 Oct 2025 10:00:32 -0400 [thread overview]
Message-ID: <224f73ab69718644c67700bed579d48e5331b81f.camel@kernel.org> (raw)
In-Reply-To: <20251001132431.9882-1-cel@kernel.org>
On Wed, 2025-10-01 at 09:24 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> TIME_CREATE has been supported since commit e377a3e698fb ("nfsd: Add
> support for the birth time attribute").
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfsd.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index bdb60ee1f1a4..6812cd231b1d 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -395,14 +395,13 @@ enum {
> #define NFSD_CB_GETATTR_TIMEOUT NFSD_DELEGRETURN_TIMEOUT
>
> /*
> - * The following attributes are currently not supported by the NFSv4 server:
> + * The following attributes are not implemented by NFSD:
> * ARCHIVE (deprecated anyway)
> * HIDDEN (unlikely to be supported any time soon)
> * MIMETYPE (unlikely to be supported any time soon)
> * QUOTA_* (will be supported in a forthcoming patch)
> * SYSTEM (unlikely to be supported any time soon)
> * TIME_BACKUP (unlikely to be supported any time soon)
> - * TIME_CREATE (unlikely to be supported any time soon)
> */
> #define NFSD4_SUPPORTED_ATTRS_WORD0 \
> (FATTR4_WORD0_SUPPORTED_ATTRS | FATTR4_WORD0_TYPE | FATTR4_WORD0_FH_EXPIRE_TYPE \
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-10-01 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 13:24 [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes Chuck Lever
2025-10-01 14:00 ` Jeff Layton [this message]
2025-10-01 15:41 ` FATTR4_WORD1_TIME_CREATE support in NFSv4 client still missing? " Aurélien Couderc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=224f73ab69718644c67700bed579d48e5331b81f.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=dai.ngo@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neil@brown.name \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox