* [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes
@ 2025-10-01 13:24 Chuck Lever
2025-10-01 14:00 ` Jeff Layton
2025-10-01 15:41 ` FATTR4_WORD1_TIME_CREATE support in NFSv4 client still missing? " Aurélien Couderc
0 siblings, 2 replies; 3+ messages in thread
From: Chuck Lever @ 2025-10-01 13:24 UTC (permalink / raw)
To: NeilBrown, Jeff Layton, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, Chuck Lever
From: Chuck Lever <chuck.lever@oracle.com>
TIME_CREATE has been supported since commit e377a3e698fb ("nfsd: Add
support for the birth time attribute").
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
fs/nfsd/nfsd.h | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
index bdb60ee1f1a4..6812cd231b1d 100644
--- a/fs/nfsd/nfsd.h
+++ b/fs/nfsd/nfsd.h
@@ -395,14 +395,13 @@ enum {
#define NFSD_CB_GETATTR_TIMEOUT NFSD_DELEGRETURN_TIMEOUT
/*
- * The following attributes are currently not supported by the NFSv4 server:
+ * The following attributes are not implemented by NFSD:
* ARCHIVE (deprecated anyway)
* HIDDEN (unlikely to be supported any time soon)
* MIMETYPE (unlikely to be supported any time soon)
* QUOTA_* (will be supported in a forthcoming patch)
* SYSTEM (unlikely to be supported any time soon)
* TIME_BACKUP (unlikely to be supported any time soon)
- * TIME_CREATE (unlikely to be supported any time soon)
*/
#define NFSD4_SUPPORTED_ATTRS_WORD0 \
(FATTR4_WORD0_SUPPORTED_ATTRS | FATTR4_WORD0_TYPE | FATTR4_WORD0_FH_EXPIRE_TYPE \
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes
2025-10-01 13:24 [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes Chuck Lever
@ 2025-10-01 14:00 ` Jeff Layton
2025-10-01 15:41 ` FATTR4_WORD1_TIME_CREATE support in NFSv4 client still missing? " Aurélien Couderc
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Layton @ 2025-10-01 14:00 UTC (permalink / raw)
To: Chuck Lever, NeilBrown, Olga Kornievskaia, Dai Ngo, Tom Talpey
Cc: linux-nfs, Chuck Lever
On Wed, 2025-10-01 at 09:24 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> TIME_CREATE has been supported since commit e377a3e698fb ("nfsd: Add
> support for the birth time attribute").
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfsd.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index bdb60ee1f1a4..6812cd231b1d 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -395,14 +395,13 @@ enum {
> #define NFSD_CB_GETATTR_TIMEOUT NFSD_DELEGRETURN_TIMEOUT
>
> /*
> - * The following attributes are currently not supported by the NFSv4 server:
> + * The following attributes are not implemented by NFSD:
> * ARCHIVE (deprecated anyway)
> * HIDDEN (unlikely to be supported any time soon)
> * MIMETYPE (unlikely to be supported any time soon)
> * QUOTA_* (will be supported in a forthcoming patch)
> * SYSTEM (unlikely to be supported any time soon)
> * TIME_BACKUP (unlikely to be supported any time soon)
> - * TIME_CREATE (unlikely to be supported any time soon)
> */
> #define NFSD4_SUPPORTED_ATTRS_WORD0 \
> (FATTR4_WORD0_SUPPORTED_ATTRS | FATTR4_WORD0_TYPE | FATTR4_WORD0_FH_EXPIRE_TYPE \
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* FATTR4_WORD1_TIME_CREATE support in NFSv4 client still missing? Re: [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes
2025-10-01 13:24 [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes Chuck Lever
2025-10-01 14:00 ` Jeff Layton
@ 2025-10-01 15:41 ` Aurélien Couderc
1 sibling, 0 replies; 3+ messages in thread
From: Aurélien Couderc @ 2025-10-01 15:41 UTC (permalink / raw)
To: linux-nfs
On Wed, Oct 1, 2025 at 3:27 PM Chuck Lever <cel@kernel.org> wrote:
>
> From: Chuck Lever <chuck.lever@oracle.com>
>
> TIME_CREATE has been supported since commit e377a3e698fb ("nfsd: Add
> support for the birth time attribute").
>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfsd.h | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsd.h b/fs/nfsd/nfsd.h
> index bdb60ee1f1a4..6812cd231b1d 100644
> --- a/fs/nfsd/nfsd.h
> +++ b/fs/nfsd/nfsd.h
> @@ -395,14 +395,13 @@ enum {
> #define NFSD_CB_GETATTR_TIMEOUT NFSD_DELEGRETURN_TIMEOUT
>
> /*
> - * The following attributes are currently not supported by the NFSv4 server:
> + * The following attributes are not implemented by NFSD:
> * ARCHIVE (deprecated anyway)
> * HIDDEN (unlikely to be supported any time soon)
> * MIMETYPE (unlikely to be supported any time soon)
> * QUOTA_* (will be supported in a forthcoming patch)
> * SYSTEM (unlikely to be supported any time soon)
> * TIME_BACKUP (unlikely to be supported any time soon)
> - * TIME_CREATE (unlikely to be supported any time soon)
> */
> #define NFSD4_SUPPORTED_ATTRS_WORD0 \
> (FATTR4_WORD0_SUPPORTED_ATTRS | FATTR4_WORD0_TYPE | FATTR4_WORD0_FH_EXPIRE_TYPE \
What about the Linux NFSv4 client side patches for
FATTR4_WORD1_TIME_CREATE? That support is still... not there.
Aurélien
--
Aurélien Couderc <aurelien.couderc2002@gmail.com>
Big Data/Data mining expert, chess enthusiast
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-01 15:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-01 13:24 [PATCH] NFSD: Update comment documenting unsupported fattr4 attributes Chuck Lever
2025-10-01 14:00 ` Jeff Layton
2025-10-01 15:41 ` FATTR4_WORD1_TIME_CREATE support in NFSv4 client still missing? " Aurélien Couderc
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox