From: David Howells <dhowells@redhat.com>
To: Suresh Jayaraman <sjayaraman@suse.de>
Cc: dhowells@redhat.com, trond.myklebust@netapp.com,
Linux NFS mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [RFC][PATCH] nfs: don't assume fscache_acquire_cookie will always succeed
Date: Thu, 21 Jan 2010 11:07:07 +0000 [thread overview]
Message-ID: <29178.1264072027@redhat.com> (raw)
In-Reply-To: <4B56F565.7080104@suse.de>
Suresh Jayaraman <sjayaraman@suse.de> wrote:
> + if (!clp->fscache)
> + goto error_cleanup;
This should be unnecessary. FS-Cache's API functions in linux/fscache.h
should handle a NULL cookie and do the right thing.
David
next prev parent reply other threads:[~2010-01-21 11:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-20 12:21 [RFC][PATCH] nfs: don't assume fscache_acquire_cookie will always succeed Suresh Jayaraman
2010-01-20 21:35 ` Trond Myklebust
2010-01-21 11:07 ` David Howells [this message]
2010-01-21 11:41 ` Suresh Jayaraman
2010-01-22 12:52 ` Suresh Jayaraman
2010-01-23 3:48 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29178.1264072027@redhat.com \
--to=dhowells@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=sjayaraman@suse.de \
--cc=trond.myklebust@netapp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox