From: Jeff Layton <jlayton@kernel.org>
To: Leo Martins <loemra.dev@gmail.com>,
linux-nfs@vger.kernel.org, kernel-team@fb.com,
trondmy@kernel.org, anna@kernel.org
Subject: Re: [PATCH] nfs: cleanup tracepoint declarations
Date: Thu, 21 Aug 2025 18:38:55 -0400 [thread overview]
Message-ID: <2939c807864058f64530acc1038736b6fec7a3d3.camel@kernel.org> (raw)
In-Reply-To: <521823b0d5aec48f9cc79c01bdda054e49f45170.1755812833.git.loemra.dev@gmail.com>
On Thu, 2025-08-21 at 15:04 -0700, Leo Martins wrote:
> Cleanup tracepoint declarations by replacing commas with
> semicolons to better match other tracepoint declarations.
>
> No functional changes introduced.
>
> Signed-off-by: Leo Martins <loemra.dev@gmail.com>
> ---
> fs/nfs/nfstrace.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/nfstrace.h b/fs/nfs/nfstrace.h
> index 96b1323318c2..d7ddf3bb5402 100644
> --- a/fs/nfs/nfstrace.h
> +++ b/fs/nfs/nfstrace.h
> @@ -966,7 +966,7 @@ DECLARE_EVENT_CLASS(nfs_folio_event,
> __entry->fileid = nfsi->fileid;
> __entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
> __entry->version = inode_peek_iversion_raw(inode);
> - __entry->offset = offset,
> + __entry->offset = offset;
> __entry->count = count;
> ),
>
> @@ -1016,8 +1016,8 @@ DECLARE_EVENT_CLASS(nfs_folio_event_done,
> __entry->fileid = nfsi->fileid;
> __entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
> __entry->version = inode_peek_iversion_raw(inode);
> - __entry->offset = offset,
> - __entry->count = count,
> + __entry->offset = offset;
> + __entry->count = count;
> __entry->ret = ret;
> ),
>
Harmless in this case (luckily), but it's nice to remove a potential
footgun.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2025-08-21 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-21 22:04 [PATCH] nfs: cleanup tracepoint declarations Leo Martins
2025-08-21 22:38 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2939c807864058f64530acc1038736b6fec7a3d3.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=anna@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-nfs@vger.kernel.org \
--cc=loemra.dev@gmail.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox