* [PATCH] nfs: cleanup tracepoint declarations
@ 2025-08-21 22:04 Leo Martins
2025-08-21 22:38 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Leo Martins @ 2025-08-21 22:04 UTC (permalink / raw)
To: linux-nfs, kernel-team, trondmy, anna, jlayton
Cleanup tracepoint declarations by replacing commas with
semicolons to better match other tracepoint declarations.
No functional changes introduced.
Signed-off-by: Leo Martins <loemra.dev@gmail.com>
---
fs/nfs/nfstrace.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/nfs/nfstrace.h b/fs/nfs/nfstrace.h
index 96b1323318c2..d7ddf3bb5402 100644
--- a/fs/nfs/nfstrace.h
+++ b/fs/nfs/nfstrace.h
@@ -966,7 +966,7 @@ DECLARE_EVENT_CLASS(nfs_folio_event,
__entry->fileid = nfsi->fileid;
__entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
__entry->version = inode_peek_iversion_raw(inode);
- __entry->offset = offset,
+ __entry->offset = offset;
__entry->count = count;
),
@@ -1016,8 +1016,8 @@ DECLARE_EVENT_CLASS(nfs_folio_event_done,
__entry->fileid = nfsi->fileid;
__entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
__entry->version = inode_peek_iversion_raw(inode);
- __entry->offset = offset,
- __entry->count = count,
+ __entry->offset = offset;
+ __entry->count = count;
__entry->ret = ret;
),
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfs: cleanup tracepoint declarations
2025-08-21 22:04 [PATCH] nfs: cleanup tracepoint declarations Leo Martins
@ 2025-08-21 22:38 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2025-08-21 22:38 UTC (permalink / raw)
To: Leo Martins, linux-nfs, kernel-team, trondmy, anna
On Thu, 2025-08-21 at 15:04 -0700, Leo Martins wrote:
> Cleanup tracepoint declarations by replacing commas with
> semicolons to better match other tracepoint declarations.
>
> No functional changes introduced.
>
> Signed-off-by: Leo Martins <loemra.dev@gmail.com>
> ---
> fs/nfs/nfstrace.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/nfs/nfstrace.h b/fs/nfs/nfstrace.h
> index 96b1323318c2..d7ddf3bb5402 100644
> --- a/fs/nfs/nfstrace.h
> +++ b/fs/nfs/nfstrace.h
> @@ -966,7 +966,7 @@ DECLARE_EVENT_CLASS(nfs_folio_event,
> __entry->fileid = nfsi->fileid;
> __entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
> __entry->version = inode_peek_iversion_raw(inode);
> - __entry->offset = offset,
> + __entry->offset = offset;
> __entry->count = count;
> ),
>
> @@ -1016,8 +1016,8 @@ DECLARE_EVENT_CLASS(nfs_folio_event_done,
> __entry->fileid = nfsi->fileid;
> __entry->fhandle = nfs_fhandle_hash(&nfsi->fh);
> __entry->version = inode_peek_iversion_raw(inode);
> - __entry->offset = offset,
> - __entry->count = count,
> + __entry->offset = offset;
> + __entry->count = count;
> __entry->ret = ret;
> ),
>
Harmless in this case (luckily), but it's nice to remove a potential
footgun.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-08-21 22:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-08-21 22:04 [PATCH] nfs: cleanup tracepoint declarations Leo Martins
2025-08-21 22:38 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox