From: Trond Myklebust <trond.myklebust@primarydata.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Russell King - ARM Linux <linux@arm.linux.org.uk>,
linuxnfs <linux-nfs@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Viro Alexander <viro@zeniv.linux.org.uk>,
Christoph Hellwig <hch@lst.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: NFS client broken in Linus' tip
Date: Mon, 3 Feb 2014 10:45:48 -0500 [thread overview]
Message-ID: <3003D7E5-93F8-4B32-ACDB-07ED3F6CE70D@primarydata.com> (raw)
In-Reply-To: <20140203145759.GA30263@infradead.org>
On Feb 3, 2014, at 9:57, Christoph Hellwig <hch@infradead.org> wrote:
> On Mon, Feb 03, 2014 at 09:17:30AM -0500, Trond Myklebust wrote:
>> As I said above, that causes posix_acl_xattr_get() to return the wrong answer (ENODATA instead of EOPNOTSUPP).
>
> Is it really the wrong answer? How does userspace care wether this
> server doesn't support ACLs at all or none is set? The resulting
> behavior is the same.
It will certainly cause acl_get_file() to behave differently than previously. I’ve no idea how that will affect applications, though.
> If there's a good reason to care we might have to go with your patch,
> but if we can avoid it I'd prefer to keep things simple.
One alternative is to simply wrap posix_acl_xattr_get() in fs/nfs/nfs3acl.c, and have it check the value of nfs_server_capable(inode, NFS_CAP_ACLS) before returning ENODATA. That’s rather ugly too...
--
Trond Myklebust
Linux NFS client maintainer
next prev parent reply other threads:[~2014-02-03 15:45 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-30 14:08 NFS client broken in Linus' tip Russell King - ARM Linux
2014-01-30 14:14 ` Christoph Hellwig
2014-01-30 14:27 ` Russell King - ARM Linux
2014-01-30 14:32 ` Christoph Hellwig
2014-01-30 15:38 ` Russell King - ARM Linux
2014-01-31 20:59 ` Trond Myklebust
2014-02-01 1:03 ` Russell King - ARM Linux
2014-02-02 12:27 ` Russell King - ARM Linux
2014-02-02 22:04 ` Trond Myklebust
2014-02-03 9:43 ` Takashi Iwai
2014-02-03 14:21 ` Trond Myklebust
2014-02-03 14:24 ` Takashi Iwai
2014-02-03 8:03 ` Christoph Hellwig
2014-02-03 14:17 ` Trond Myklebust
2014-02-03 14:57 ` Christoph Hellwig
2014-02-03 15:45 ` Trond Myklebust [this message]
2014-02-03 20:22 ` Trond Myklebust
2014-02-03 20:25 ` Russell King - ARM Linux
2014-02-03 20:25 ` Christoph Hellwig
2014-02-03 20:32 ` Trond Myklebust
2014-02-03 20:54 ` Christoph Hellwig
2014-01-30 14:17 ` Trond Myklebust
2014-01-30 14:30 ` Russell King - ARM Linux
2014-01-30 14:45 ` Trond Myklebust
2014-01-30 15:17 ` Root NFS panicing on Linus' tip (Re: NFS client broken in Linus' tip) Ezequiel Garcia
2014-01-30 16:08 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3003D7E5-93F8-4B32-ACDB-07ED3F6CE70D@primarydata.com \
--to=trond.myklebust@primarydata.com \
--cc=hch@infradead.org \
--cc=hch@lst.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox