From: David Howells <dhowells@redhat.com>
To: Chuck Lever <cel@kernel.org>
Cc: dhowells@redhat.com, linux-nfs@vger.kernel.org,
Jan Schunk <scpcom@gmx.de>,
Alexander Duyck <alexander.duyck@gmail.com>,
Jakub Kacinski <kuba@kernel.org>,
Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH 2] SUNRPC: Fix a slow server-side memory leak with RPC-over-TCP
Date: Thu, 04 Apr 2024 14:04:17 +0100 [thread overview]
Message-ID: <3747895.1712235857@warthog.procyon.org.uk> (raw)
In-Reply-To: <171215477898.1643.12386933275741788356.stgit@klimt.1015granger.net>
Chuck Lever <cel@kernel.org> wrote:
> That commit assumed that sock_sendmsg() releases all the pages in
> the underlying bio_vec array, but the reality is that it doesn't.
> svc_xprt_release() releases the rqst's response pages, but the
> record marker page fragment isn't one of those, so it is never
> released.
More like the network layer will take its own refs and drop those when it is
done. As you say, it doesn't release the caller's refs.
Reviewed-by: David Howells <dhowells@redhat.com>
prev parent reply other threads:[~2024-04-04 13:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 14:36 [PATCH 2] SUNRPC: Fix a slow server-side memory leak with RPC-over-TCP Chuck Lever
2024-04-04 13:04 ` David Howells [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3747895.1712235857@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=alexander.duyck@gmail.com \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=kuba@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=scpcom@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox